- Notifications
You must be signed in to change notification settings - Fork61
chore(deps): update all dependencies#1248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Summary of ChangesHello@renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on maintaining the project's dependencies by upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign uphere. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Code Review
This PR updates theapache-beam dependency tov2.70.0. While this is a straightforward version bump, I've noticed a potential issue regarding Python 3.12 compatibility. The project's test configuration (noxfile_config.py) explicitly states that Beam is not yet supported on Python 3.12. To prevent issues for users of this sample, I've suggested a modification to therequirements.txt file to exclude Python 3.12 from this dependency version.
| @@ -1,4 +1,4 @@ | |||
| apache-beam===2.60.0;python_version=='3.8' | |||
| apache-beam==2.69.0;python_version>='3.9' | |||
| apache-beam==2.70.0;python_version>='3.9' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Based on thenoxfile_config.py in this sample's directory, it appears thatapache-beam does not yet support Python 3.12. The current version constraintpython_version >= '3.9' could lead to installation or runtime errors for users on Python 3.12. To align with the test configuration and prevent issues for users, it would be better to explicitly exclude this Python version in the dependency specification.
apache-beam==2.70.0; python_version >= '3.9' and python_version != '3.12'
Uh oh!
There was an error while loading.Please reload this page.
This PR contains the following updates:
==2.69.0->==2.70.0==2.34.0->==2.35.0Release Notes
googleapis/python-bigtable (google-cloud-bigtable)
v2.35.0Compare Source
Features
Bug Fixes
Configuration
📅Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻Immortal: This PR will be recreated if closed unmerged. Getconfig help if that's undesired.
This PR was generated byMend Renovate. View therepository job log.