Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix: Resolve breakage where the BigQuery Dialectunnest clobbersunnest definitions in other dialects#1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
google-labs-jules wants to merge11 commits intomain
base:main
Choose a base branch
Loading
fromunnest-breakage-882

Conversation

@google-labs-jules
Copy link
Contributor

@google-labs-julesgoogle-labs-julesbot commentedOct 1, 2025
edited by chalmerlowe
Loading

This PR fixes the issue where the BigQuery unnest function overrides the unnest function for other dialects. I have made the unnest function dialect-specific to BigQuery to avoid these conflicts.

Fixes#882


PR created automatically by Jules for task13760819514326074521

BigQuery's unnest function implementation overrides and breaks this function for other dialects.This change makes the unnest function dialect-specific to BigQuery to avoid conflicts with other dialects.
@google-labs-jules
Copy link
ContributorAuthor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me toReactive Mode. When this mode is on, I will only act on comments where you specifically mention me with@jules. You can find this option in thePull Request section of yourglobal Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

@product-auto-labelproduct-auto-labelbot added size: mPull request size is medium. api: bigqueryIssues related to the googleapis/python-bigquery-sqlalchemy API. labelsOct 1, 2025
@chalmerlowechalmerlowe changed the titleFix unnest breakage for other dialectsFix: Resolve breakage where the BigQuery Dialectunnest clobbersunnest definitions in other dialectsOct 1, 2025
@chalmerlowechalmerlowe marked this pull request as ready for reviewOctober 1, 2025 12:24
@chalmerlowechalmerlowe requested review froma team ascode ownersOctober 1, 2025 12:24
daniel-sanche
daniel-sanche previously approved these changesOct 6, 2025
Copy link

@daniel-sanchedaniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not familiar with the details of sqlalchemy, but the changes LGTM

@shollymanshollyman requested review fromchalmerlowe and removed request forshollymanOctober 8, 2025 16:57
chalmerlowe
chalmerlowe previously approved these changesOct 8, 2025
Copy link
Collaborator

@chalmerlowechalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@chalmerlowechalmerlowe added the kokoro:runAdd this label to force Kokoro to re-run the tests. labelOct 8, 2025
@yoshi-kokoroyoshi-kokoro removed the kokoro:runAdd this label to force Kokoro to re-run the tests. labelOct 8, 2025
@chalmerlowechalmerlowe dismissed stale reviews fromdaniel-sanche and themself viad56c3e4October 8, 2025 20:39
@chalmerlowechalmerlowe added the kokoro:runAdd this label to force Kokoro to re-run the tests. labelOct 8, 2025
@yoshi-kokoroyoshi-kokoro removed the kokoro:runAdd this label to force Kokoro to re-run the tests. labelOct 8, 2025
@chalmerlowechalmerloweenabled auto-merge (squash)October 13, 2025 13:19
chalmerlowe
chalmerlowe previously approved these changesOct 13, 2025
Copy link
Collaborator

@chalmerlowechalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

daniel-sanche
daniel-sanche previously approved these changesOct 13, 2025
@chalmerlowechalmerlowe added the kokoro:runAdd this label to force Kokoro to re-run the tests. labelOct 13, 2025
@yoshi-kokoroyoshi-kokoro removed the kokoro:runAdd this label to force Kokoro to re-run the tests. labelOct 13, 2025
@chalmerlowechalmerlowe dismissed stale reviews fromdaniel-sanche and themself via50587d8October 16, 2025 10:07
@chalmerlowechalmerlowe added the kokoro:runAdd this label to force Kokoro to re-run the tests. labelOct 16, 2025
@yoshi-kokoroyoshi-kokoro removed the kokoro:runAdd this label to force Kokoro to re-run the tests. labelOct 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@daniel-sanchedaniel-sanchedaniel-sanche left review comments

@chalmerlowechalmerlowechalmerlowe left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@chalmerlowechalmerlowe

Labels

api: bigqueryIssues related to the googleapis/python-bigquery-sqlalchemy API.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BigQuery's unnest function implementation overrides and breaks this function for other dialects

4 participants

@daniel-sanche@chalmerlowe@yirutang@yoshi-kokoro

[8]ページ先頭

©2009-2025 Movatter.jp