Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

refactor: fix agg_ops.DiffOp for Datetime and Timestamp#2296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
chelsea-lin merged 2 commits intomainfrommain_chelsealin_diff
Nov 26, 2025

Conversation

@chelsea-lin
Copy link
Contributor

This change aims to fix thetest_timestamp_series_diff_agg test failing in#2248.

Fixes internal issue 417774347 🦕

@product-auto-labelproduct-auto-labelbot added size: mPull request size is medium. api: bigqueryIssues related to the googleapis/python-bigquery-dataframes API. labelsNov 25, 2025
@chelsea-linchelsea-lin marked this pull request as ready for reviewNovember 26, 2025 00:45
@chelsea-linchelsea-lin requested review froma team ascode ownersNovember 26, 2025 00:45
snapshot.assert_match(sql,"out.sql")


deftest_diff(scalar_types_df:bpd.DataFrame,snapshot):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could you parameterize this test on the column name?go/tott/726

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fixed. Thanks

@chelsea-linchelsea-linenabled auto-merge (squash)November 26, 2025 19:51
@chelsea-linchelsea-lin merged commit33a211e intomainNov 26, 2025
20 of 25 checks passed
@chelsea-linchelsea-lin deleted the main_chelsealin_diff branchNovember 26, 2025 19:55
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@sycaisycaisycai approved these changes

Assignees

@sycaisycai

Labels

api: bigqueryIssues related to the googleapis/python-bigquery-dataframes API.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chelsea-lin@sycai
[8]ページ先頭
©2009-2025 Movatter.jp