- Notifications
You must be signed in to change notification settings - Fork63
feat: SQL Cell no longer escapes formatted string values#2245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Updates `bigframes/core/pyformat.py` to directly embed string values in the formatted output. This allows for dynamic substitution of SQL identifiers, such as table or column names.Updated unit tests to reflect this new behavior by using valid SQL identifiers in the test cases.
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me toReactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more atjules.google/docs. |
tswast commentedNov 10, 2025
@google-labs-jules It seems this may be related to this change. Please fix. |
You are right, that test was failing due to my changes. I have now fixed the test. Thank you for catching that! |
I have generated the requested changes, but I was unable to publish them to the branch. You can publish the changes manually from theJules UI. |
This commit fixes a unit test that was failing due to the changes in pyformat. The test is updated to pass a pre-quoted string, ensuring the resulting SQL is valid.
tswast commentedNov 10, 2025
Remaining test should be fixed by#2246 |
Thank you for the information. I will consider my work on this issue complete. |
Updates `bigframes/core/pyformat.py` to directly embed string values in the formatted output. This allows for dynamic substitution of SQL identifiers, such as table or column names.Updated unit tests to reflect this new behavior by using valid SQL identifiers in the test cases.
d2d38f9 intomainUh oh!
There was an error while loading.Please reload this page.
🤖 I have created a release *beep* *boop*---##[2.29.0](v2.28.0...v2.29.0)(2025-11-10)### Features* Add bigframes.bigquery.st_regionstats to join raster data from EarthEngine([#2228](#2228))([10ec52f](10ec52f))* Add DataFrame.resample and Series.resample([#2213](#2213))([c9ca02c](c9ca02c))* SQL Cell no longer escapes formatted string values([#2245](#2245))([d2d38f9](d2d38f9))* Support left_index and right_index for merge([#2220](#2220))([da9ba26](da9ba26))### Bug Fixes* Correctly iterate over null struct values in ManagedArrowTable([#2209](#2209))([12e04d5](12e04d5))* Simplify UnsupportedTypeError message([#2212](#2212))([6c9a18d](6c9a18d))* Support results with STRUCT and ARRAY columns containing JSONsubfields in `to_pandas_batches()`([#2216](#2216))([3d8b17f](3d8b17f))### Documentation* Switch API reference docs to pydata theme([#2237](#2237))([9b86dcf](9b86dcf))* Update notebook for JSON subfields support in to_pandas_batches()([#2138](#2138))([5663d2a](5663d2a))---This PR was generated with [ReleasePlease](https://github.com/googleapis/release-please). See[documentation](https://github.com/googleapis/release-please#release-please).Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This change updates bigframes/core/pyformat.py to directly embed str values rather than escaping them first. Unit tests have been updated to reflect this change.
PR created automatically by Jules for task5189763854933796072