Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: disambiguate missing policy tags from explicitly unset policy tags#983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@tswast
Copy link
Contributor

@tswasttswast commentedSep 22, 2021•
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#981
Fixes#982
Towardsgoogleapis/python-bigquery-pandas#387
🦕

@tswasttswast requested a review froma teamSeptember 22, 2021 20:24
@tswasttswast requested a review froma team as acode ownerSeptember 22, 2021 20:24
@product-auto-labelproduct-auto-labelbot added the api: bigqueryIssues related to the googleapis/python-bigquery API. labelSep 22, 2021
@google-clagoogle-clabot added the cla: yesThis human has signed the Contributor License Agreement. labelSep 22, 2021
Copy link
Contributor

@plamutplamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good (with one minor nit), seems like we just need to adjust the type annotation and it should be good.

@tswasttswast requested a review fromplamutSeptember 23, 2021 21:24
Copy link
Contributor

@plamutplamut left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, except for a typo.

Edit: Just fixed it myself.

@plamutplamut added the automergeMerge the pull request once unit tests and other checks pass. labelSep 24, 2021
@gcf-merge-on-greengcf-merge-on-greenbot merged commitf83c00a intogoogleapis:mainSep 24, 2021
@gcf-merge-on-greengcf-merge-on-greenbot removed the automergeMerge the pull request once unit tests and other checks pass. labelSep 24, 2021
@tswasttswast deleted the issue981-policyTags branchSeptember 24, 2021 15:47
judahrand pushed a commit to judahrand/python-bigquery that referenced this pull requestSep 27, 2021
…gs (googleapis#983)Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea- [ ] Ensure the tests and linter pass- [ ] Code coverage does not decrease (if any source code was changed)- [ ] Appropriate docs were updated (if necessary)Fixesgoogleapis#981Fixesgoogleapis#982Towardsgoogleapis/python-bigquery-pandas#387🦕
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull requestApr 17, 2023
…gs (googleapis#983)Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea- [ ] Ensure the tests and linter pass- [ ] Code coverage does not decrease (if any source code was changed)- [ ] Appropriate docs were updated (if necessary)Fixesgoogleapis#981Fixesgoogleapis#982Towardsgoogleapis/python-bigquery-pandas#387🦕
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stephaniewang526stephaniewang526Awaiting requested review from stephaniewang526

1 more reviewer

@plamutplamutplamut approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

missing docs forgoogle.cloud.bigquery.schema.PolicyTagList disambiguate missing policy tags from explicitly unset policy tags

2 participants

@tswast@plamut
[8]ページ先頭
©2009-2025 Movatter.jp