- Notifications
You must be signed in to change notification settings - Fork321
chore: sync v3 branch with main#947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
* chore: protect v3.x.x branchIn preparation for breaking changes.* force pattern to be a string* simplify branch name
…googleapis#815)That warning should only be used when BQ Storage client isexplicitly passed in to RowIterator methods when max_resultsvalue is also set.
…ields for BQML. (googleapis#817)PiperOrigin-RevId: 387137741Source-Link:googleapis/googleapis@8962c92Source-Link:https://github.com/googleapis/googleapis-gen/commit/102f1b4277cc5a049663535d9eeb77831b67de25
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
These two lines bring the rules on this repo in line with the defaults:https://github.com/googleapis/repo-automation-bots/blob/63c858e539e1f4d9bb8ea66e12f9c0a0de5fef55/packages/sync-repo-settings/src/required-checks.json#L40-L50
The backend API has a timeout of 4 minutes, so the default of 2 minutes was notallowing for any retries to happen in some cases.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea- [ ] Ensure the tests and linter pass- [ ] Code coverage does not decrease (if any source code was changed)- [ ] Appropriate docs were updated (if necessary)Fixesgoogleapis#853 🦕
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>Co-authored-by: Tim Swast <swast@google.com>
…leapis#866)[](https://renovatebot.com)This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---|| [google-cloud-bigquery](https://togithub.com/googleapis/python-bigquery) | `==2.23.2` -> `==2.23.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) |***### Release Notes<details><summary>googleapis/python-bigquery</summary>### [`v2.23.3`](https://togithub.com/googleapis/python-bigquery/blob/master/CHANGELOG.md#2233-httpswwwgithubcomgoogleapispython-bigquerycomparev2232v2233-2021-08-06)[Compare Source](https://togithub.com/googleapis/python-bigquery/compare/v2.23.2...v2.23.3)</details>***### Configuration📅 **Schedule**: At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this update again.**** \[ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.***This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-bigquery).
%5d(https%3a%2f%2frenovatebot.com){kind=link}
* feat: add support for transaction statistics* Hoist transaction_info into base job class* Add versionadded directive to new property and class* Include new class in docs reference
googleapis#863)[](https://renovatebot.com)This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---|| [google-cloud-bigquery-storage](https://togithub.com/googleapis/python-bigquery-storage) | `==2.6.2` -> `==2.6.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) |***### Release Notes<details><summary>googleapis/python-bigquery-storage</summary>### [`v2.6.3`](https://togithub.com/googleapis/python-bigquery-storage/blob/master/CHANGELOG.md#263-httpswwwgithubcomgoogleapispython-bigquery-storagecomparev262v263-2021-08-06)[Compare Source](https://togithub.com/googleapis/python-bigquery-storage/compare/v2.6.2...v2.6.3)</details>***### Configuration📅 **Schedule**: At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this update again.**** \[x] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.***This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-bigquery).
Source-Link:googleapis/synthtool@6252f2cPost-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:50e35228649c47b6ca82aa0be3ff9eb2afce51c82b66c4a03fe4afeb5ff6c0fcCo-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…s#867)* feat: make the same Table instances equal to each other* Table equality should ignore metadata differences* Compare instances through tableReference property* Make Table instances hashable* Make Table* classes interchangeableIf these classes reference the same table, they are now considered equal.
…larQueryParameter` constructor (googleapis#850)Follow-up tohttps://github.com/googleapis/python-bigquery/pull/840/files#r679880582Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea- [ ] Ensure the tests and linter pass- [ ] Code coverage does not decrease (if any source code was changed)- [ ] Appropriate docs were updated (if necessary)
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:- [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea- [x] Ensure the tests and linter pass- [x] Code coverage does not decrease (if any source code was changed)- [x] Appropriate docs were updated (if necessary)Fixesgoogleapis#539 🦕Previously, we only retried failed API requests. Now, we retry failed jobs (according to the predicate of the `Retry` object passed to `job.result()`).
…ogleapis#865)Co-authored-by: Tim Swast <swast@google.com>Co-authored-by: Tres Seaver <tseaver@palladion.com>
Contributor
tseaver commentedSep 7, 2021
@plamut Is the target branch for this PR supposed to be |
snippet-botbot commentedSep 7, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated bysnippet-bot.
|
ContributorAuthor
plamut commentedSep 7, 2021
@tseaver Yes, and thanks for noticing this bummer. |
tswast approved these changesSep 8, 2021
Contributor
tswast left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That's quite the diff! Other than a suggestion fornoxfile.py, this looks good to me.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Contributor
tswast commentedSep 8, 2021
Adding |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️Googlers:Go here for more info. |
ContributorAuthor
plamut commentedSep 9, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@tswast Thanks for going through this. The diff was large, indeed, thus we should probably do these syncs more frequently (I'm thinking at least once a week). Even just fixing the merge conflicts took quite some time, not to mention that those are prone to accidentally introducing bugs. Could you please just flip the CLA label? It seems that the bot dislikes one of the multi-author commits. |
Contributor
tswast commentedSep 9, 2021
I triggered a rebuild of the |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
api: bigqueryIssues related to the googleapis/python-bigquery API. cla: yesThis human has signed the Contributor License Agreement.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Bringing the
v3branch back to sync withmain. There were quite a few merge conflicts, thus proceed carefully. 🐞Should also fix the snippets test failure in#855.