Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: Arrow extension-type metadata was not set when calling the REST API or when there are no rows#946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@jimfulton
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#894 🦕

@product-auto-labelproduct-auto-labelbot added the api: bigqueryIssues related to the googleapis/python-bigquery API. labelSep 6, 2021
@google-clagoogle-clabot added the cla: yesThis human has signed the Contributor License Agreement. labelSep 6, 2021
@jimfultonjimfulton marked this pull request as ready for reviewSeptember 6, 2021 19:28
@jimfultonjimfulton requested a review froma teamSeptember 6, 2021 19:28
@jimfultonjimfulton requested a review froma team as acode ownerSeptember 6, 2021 19:28
@jimfultonjimfulton changed the titlefix: Arror extension-type metadata not set when calling the REST API or when there are no rowsfix: Arrow extension-type metadata not set when calling the REST API or when there are no rowsSep 6, 2021
@jimfultonjimfulton changed the titlefix: Arrow extension-type metadata not set when calling the REST API or when there are no rowsfix: Arrow extension-type metadata was not set when calling the REST API or when there are no rowsSep 6, 2021
Copy link
Contributor

@plamutplamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A few nits/questions, but generally looks good to me.

Copy link
Contributor

@plamutplamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@jimfultonjimfulton merged commit864383b intogoogleapis:mainSep 7, 2021
@jimfultonjimfulton deleted the arrow-extension-types-894 branchSeptember 7, 2021 15:16
Copy link
Contributor

@tswasttswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks

abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull requestApr 17, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tswasttswasttswast left review comments

@loferrisloferrisAwaiting requested review from loferris

+1 more reviewer

@plamutplamutplamut approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: ensure Arrow type metadata is consistent between REST and BQ Storage APIs

3 participants

@jimfulton@tswast@plamut
[8]ページ先頭
©2009-2025 Movatter.jp