- Notifications
You must be signed in to change notification settings - Fork321
feat: Destination tables are no-longer removed by create_job#891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
jimfulton merged 2 commits intogoogleapis:v3fromjimfulton:Dont-remove-destinationTable-in-create_job-483Aug 23, 2021
Merged
feat: Destination tables are no-longer removed by create_job#891
jimfulton merged 2 commits intogoogleapis:v3fromjimfulton:Dont-remove-destinationTable-in-create_job-483Aug 23, 2021
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
plamut approved these changesAug 23, 2021
Contributor
plamut left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Trivial lint error aside (unused import), this looks good.
| ) | ||
| elif"query"injob_config: | ||
| copy_config=copy.deepcopy(job_config) | ||
| _del_sub_prop(copy_config, ["query","destinationTable"]) |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Given that we are no longer removing the property, we could just collapse this whole clause into:
elif"query"injob_config:query_job_config=google.cloud.bigquery.job.QueryJobConfig.from_api_repr(job_config )
ContributorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good idea.#893
4 tasks
tswast added a commit that referenced this pull requestMar 29, 2022
deps!: BigQuery Storage and pyarrow are required dependencies (#776)fix!: use nullable `Int64` and `boolean` dtypes in `to_dataframe` (#786) feat!: destination tables are no-longer removed by `create_job` (#891)feat!: In `to_dataframe`, use `dbdate` and `dbtime` dtypes from db-dtypes package for BigQuery DATE and TIME columns (#972)fix!: automatically convert out-of-bounds dates in `to_dataframe`, remove `date_as_object` argument (#972)feat!: mark the package as type-checked (#1058)feat!: default to DATETIME type when loading timezone-naive datetimes from Pandas (#1061)feat: add `api_method` parameter to `Client.query` to select `INSERT` or `QUERY` API (#967)fix: improve type annotations for mypy validation (#1081)feat: use `StandardSqlField` class for `Model.feature_columns` and `Model.label_columns` (#1117)docs: Add migration guide from version 2.x to 3.x (#1027)Release-As: 3.0.0
waltaskew pushed a commit to waltaskew/python-bigquery that referenced this pull requestJul 20, 2022
deps!: BigQuery Storage and pyarrow are required dependencies (googleapis#776)fix!: use nullable `Int64` and `boolean` dtypes in `to_dataframe` (googleapis#786) feat!: destination tables are no-longer removed by `create_job` (googleapis#891)feat!: In `to_dataframe`, use `dbdate` and `dbtime` dtypes from db-dtypes package for BigQuery DATE and TIME columns (googleapis#972)fix!: automatically convert out-of-bounds dates in `to_dataframe`, remove `date_as_object` argument (googleapis#972)feat!: mark the package as type-checked (googleapis#1058)feat!: default to DATETIME type when loading timezone-naive datetimes from Pandas (googleapis#1061)feat: add `api_method` parameter to `Client.query` to select `INSERT` or `QUERY` API (googleapis#967)fix: improve type annotations for mypy validation (googleapis#1081)feat: use `StandardSqlField` class for `Model.feature_columns` and `Model.label_columns` (googleapis#1117)docs: Add migration guide from version 2.x to 3.x (googleapis#1027)Release-As: 3.0.0
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull requestApr 17, 2023
deps!: BigQuery Storage and pyarrow are required dependencies (googleapis#776)fix!: use nullable `Int64` and `boolean` dtypes in `to_dataframe` (googleapis#786) feat!: destination tables are no-longer removed by `create_job` (googleapis#891)feat!: In `to_dataframe`, use `dbdate` and `dbtime` dtypes from db-dtypes package for BigQuery DATE and TIME columns (googleapis#972)fix!: automatically convert out-of-bounds dates in `to_dataframe`, remove `date_as_object` argument (googleapis#972)feat!: mark the package as type-checked (googleapis#1058)feat!: default to DATETIME type when loading timezone-naive datetimes from Pandas (googleapis#1061)feat: add `api_method` parameter to `Client.query` to select `INSERT` or `QUERY` API (googleapis#967)fix: improve type annotations for mypy validation (googleapis#1081)feat: use `StandardSqlField` class for `Model.feature_columns` and `Model.label_columns` (googleapis#1117)docs: Add migration guide from version 2.x to 3.x (googleapis#1027)Release-As: 3.0.0
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
api: bigqueryIssues related to the googleapis/python-bigquery API. cla: yesThis human has signed the Contributor License Agreement.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes#483 🦕