NotificationsYou must be signed in to change notification settings
Fork321
Star786

feat: add support for table snapshots#740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

plamut merged 7 commits intogoogleapis:masterfromplamut:iss-730

Jul 10, 2021

Merged

feat: add support for table snapshots#740

plamut merged 7 commits intogoogleapis:masterfromplamut:iss-730

Jul 10, 2021

+260 −2

Conversation

Copy link

Contributor

plamut commentedJul 8, 2021

Closes#730.

This PR adds support for handling table snapshots, as per specs.

PR checklist:

Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

plamut added2 commits

July 8, 2021 10:10

feat: add support for table snapshots

e85f437

Add system test for table snapshots

29e88ad

plamut requested review froma team andshollyman

July 8, 2021 08:39

plamut requested a review froma team as acode owner

July 8, 2021 08:39

product-auto-labelbot added the api: bigqueryIssues related to the googleapis/python-bigquery API. label

Jul 8, 2021

google-clabot added the cla: yesThis human has signed the Contributor License Agreement. label

Jul 8, 2021

Make test taxonomy resource name unique

47e1a58

tseaver suggested changes

Jul 8, 2021

View reviewed changes

google/cloud/bigquery/table.py OutdatedShow resolvedHide resolved

tests/system/test_client.py OutdatedShow resolvedHide resolved

tests/unit/job/test_copy.py OutdatedShow resolvedHide resolved

plamut requested a review fromtseaver

July 9, 2021 13:02

plamut added2 commits

July 9, 2021 16:34

Store timezone aware snapshot time on snapshots

5f21c2f

Make copy config tests more detailed

210517a

plamut force-pushed theiss-730 branch from0b2376a to210517aCompare

July 9, 2021 14:35

Copy link

google-clabot commentedJul 9, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment@googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️Googlers:Go here for more info.

google-clabot added cla: noThis human has *not* signed the Contributor License Agreement. and removed cla: yesThis human has signed the Contributor License Agreement. labels

Jul 9, 2021

Copy link

Contributor

tseaver commentedJul 9, 2021

@googlebot I fixed it.

Copy link

google-clabot commentedJul 9, 2021

ℹ️Googlers:Go here for more info.

Copy link

Contributor

tseaver commentedJul 9, 2021

@plamut Ugh, sorry about the CLA mess. Just edit me out of the history.

Copy link

ContributorAuthor

plamut commentedJul 9, 2021•
edited
Loading

Oh dear, the CLA bot again :/

@tswast Can you please help?

Edit:@tseaver Yeah, will do that, will be faster,

Use unique resource ID differently for display name

9c60aac

plamut force-pushed theiss-730 branch from5d844cb to9c60aacCompare

July 9, 2021 14:53

google-clabot added cla: yesThis human has signed the Contributor License Agreement. and removed cla: noThis human has *not* signed the Contributor License Agreement. labels

Jul 9, 2021

tseaver approved these changes

Jul 9, 2021

View reviewed changes

tswast reviewed

Jul 9, 2021

View reviewed changes

Copy link

Contributor

tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, thanks. Could you also add the new classes tohttps://github.com/googleapis/python-bigquery/blob/master/docs/reference.rst ?

shollyman approved these changes

Jul 9, 2021

View reviewed changes

tests/system/test_client.pyShow resolvedHide resolved

Copy link

ContributorAuthor

plamut commentedJul 10, 2021•
edited
Loading

Looks good, thanks. Could you also add the new classes tohttps://github.com/googleapis/python-bigquery/blob/master/docs/reference.rst ?

I thought they will be added automatically? Will do it, thanks for catching that.

(well, apparently BigQuery docs are structured a bit differently than PubSub's 🙃 )

Add new classes to docs

1ae4d25

plamut added the automergeMerge the pull request once unit tests and other checks pass. label

Jul 10, 2021

plamut merged commitba86b2a intogoogleapis:master

Jul 10, 2021

gcf-merge-on-greenbot removed the automergeMerge the pull request once unit tests and other checks pass. label

Jul 10, 2021

plamut deleted the iss-730 branch

July 10, 2021 09:29

gcf-merge-on-greenbot pushed a commit that referenced this pull request

Jul 13, 2021

chore: release 2.21.0 (#753)

7771f34

Supersedes#711.## [2.21.0](https://www.github.com/googleapis/python-bigquery/compare/v2.20.0...v2.21.0) (2021-07-13)### Features* Add max_results parameter to some of the `QueryJob` methods. ([#698](https://www.github.com/googleapis/python-bigquery/issues/698)) ([2a9618f](https://www.github.com/googleapis/python-bigquery/commit/2a9618f4daaa4a014161e1a2f7376844eec9e8da))* Add support for decimal target types. ([#735](https://www.github.com/googleapis/python-bigquery/issues/735)) ([7d2d3e9](https://www.github.com/googleapis/python-bigquery/commit/7d2d3e906a9eb161911a198fb925ad79de5df934))* Add support for table snapshots. ([#740](https://www.github.com/googleapis/python-bigquery/issues/740)) ([ba86b2a](https://www.github.com/googleapis/python-bigquery/commit/ba86b2a6300ae5a9f3c803beeb42bda4c522e34c))* Enable unsetting policy tags on schema fields. ([#703](https://www.github.com/googleapis/python-bigquery/issues/703)) ([18bb443](https://www.github.com/googleapis/python-bigquery/commit/18bb443c7acd0a75dcb57d9aebe38b2d734ff8c7))* Make it easier to disable best-effort deduplication with streaming inserts. ([#734](https://www.github.com/googleapis/python-bigquery/issues/734)) ([1246da8](https://www.github.com/googleapis/python-bigquery/commit/1246da86b78b03ca1aa2c45ec71649e294cfb2f1))* Support passing struct data to the DB API. ([#718](https://www.github.com/googleapis/python-bigquery/issues/718)) ([38b3ef9](https://www.github.com/googleapis/python-bigquery/commit/38b3ef96c3dedc139b84f0ff06885141ae7ce78c))### Bug Fixes* Inserting non-finite floats with `insert_rows()`. ([#728](https://www.github.com/googleapis/python-bigquery/issues/728)) ([d047419](https://www.github.com/googleapis/python-bigquery/commit/d047419879e807e123296da2eee89a5253050166))* Use `pandas` function to check for `NaN`. ([#750](https://www.github.com/googleapis/python-bigquery/issues/750)) ([67bc5fb](https://www.github.com/googleapis/python-bigquery/commit/67bc5fbd306be7cdffd216f3791d4024acfa95b3))### Documentation* Add docs for all enums in module. ([#745](https://www.github.com/googleapis/python-bigquery/issues/745)) ([145944f](https://www.github.com/googleapis/python-bigquery/commit/145944f24fedc4d739687399a8309f9d51d43dfd))* Omit mention of Python 2.7 in `CONTRIBUTING.rst`. ([#706](https://www.github.com/googleapis/python-bigquery/issues/706)) ([27d6839](https://www.github.com/googleapis/python-bigquery/commit/27d6839ee8a40909e4199cfa0da8b6b64705b2e9))

gcf-merge-on-greenbot pushed a commit that referenced this pull request

Jul 14, 2021

chore: release 2.21.0 (#760)

5437d44

🤖 I have created a release \*beep\* \*boop\*---## [2.21.0](https://www.github.com/googleapis/python-bigquery/compare/v2.20.0...v2.21.0) (2021-07-14)### Features* add always_use_jwt_access ([#714](https://www.github.com/googleapis/python-bigquery/issues/714)) ([92fbd4a](https://www.github.com/googleapis/python-bigquery/commit/92fbd4ade37e0be49dc278080ef73c83eafeea18))* add max_results parameter to some of the QueryJob methods ([#698](https://www.github.com/googleapis/python-bigquery/issues/698)) ([2a9618f](https://www.github.com/googleapis/python-bigquery/commit/2a9618f4daaa4a014161e1a2f7376844eec9e8da))* add support for decimal target types ([#735](https://www.github.com/googleapis/python-bigquery/issues/735)) ([7d2d3e9](https://www.github.com/googleapis/python-bigquery/commit/7d2d3e906a9eb161911a198fb925ad79de5df934))* add support for table snapshots ([#740](https://www.github.com/googleapis/python-bigquery/issues/740)) ([ba86b2a](https://www.github.com/googleapis/python-bigquery/commit/ba86b2a6300ae5a9f3c803beeb42bda4c522e34c))* enable unsetting policy tags on schema fields ([#703](https://www.github.com/googleapis/python-bigquery/issues/703)) ([18bb443](https://www.github.com/googleapis/python-bigquery/commit/18bb443c7acd0a75dcb57d9aebe38b2d734ff8c7))* make it easier to disable best-effort deduplication with streaming inserts ([#734](https://www.github.com/googleapis/python-bigquery/issues/734)) ([1246da8](https://www.github.com/googleapis/python-bigquery/commit/1246da86b78b03ca1aa2c45ec71649e294cfb2f1))* Support passing struct data to the DB API ([#718](https://www.github.com/googleapis/python-bigquery/issues/718)) ([38b3ef9](https://www.github.com/googleapis/python-bigquery/commit/38b3ef96c3dedc139b84f0ff06885141ae7ce78c))### Bug Fixes* inserting non-finite floats with insert_rows() ([#728](https://www.github.com/googleapis/python-bigquery/issues/728)) ([d047419](https://www.github.com/googleapis/python-bigquery/commit/d047419879e807e123296da2eee89a5253050166))* use pandas function to check for NaN ([#750](https://www.github.com/googleapis/python-bigquery/issues/750)) ([67bc5fb](https://www.github.com/googleapis/python-bigquery/commit/67bc5fbd306be7cdffd216f3791d4024acfa95b3))### Documentation* add docs for all enums in module ([#745](https://www.github.com/googleapis/python-bigquery/issues/745)) ([145944f](https://www.github.com/googleapis/python-bigquery/commit/145944f24fedc4d739687399a8309f9d51d43dfd))* omit mention of Python 2.7 in `CONTRIBUTING.rst` ([#706](https://www.github.com/googleapis/python-bigquery/issues/706)) ([27d6839](https://www.github.com/googleapis/python-bigquery/commit/27d6839ee8a40909e4199cfa0da8b6b64705b2e9))---This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).