Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: pin sphinx plugin version to working one#715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jimfulton merged 1 commit intomasterfromdandhlee-patch-1
Jun 24, 2021

Conversation

@dandhlee
Copy link
Contributor

There's an issue with the currentgcp-sphinx-docfx-yaml version failing for the following text:

        """Union[int, None]: Expiration time in milliseconds for a partition.        If :attr:`partition_expiration` is set and :attr:`type_` is        not set, :attr:`type_` will default to        :attr:`~google.cloud.bigquery.table.TimePartitioningType.DAY`.        """

which gets converted to

Union[int, None]: Expiration time in milliseconds for a partition.If <xref:partition_expiration> is set and <xref:type_> isnot set, <xref:type_> will default to<xref:google.cloud.bigquery.table.TimePartitioningType.DAY>.

which fails on the plugin because it thinks<xref:type_> should be a token it needs to process. The docstring is not malformed, the plugin needs additional work.

I'll have a fix for this by the end of the day, but should you need to submit PRs then please merge this one to have yourself unblocked!

Unblocks#698 🦕

@dandhleedandhlee requested a review froma teamJune 22, 2021 15:26
@dandhleedandhlee requested a review froma team as acode ownerJune 22, 2021 15:26
@dandhleedandhlee requested review fromstephaniewang526 and removed request fora teamJune 22, 2021 15:26
@product-auto-labelproduct-auto-labelbot added the api: bigqueryIssues related to the googleapis/python-bigquery API. labelJun 22, 2021
@google-clagoogle-clabot added the cla: yesThis human has signed the Contributor License Agreement. labelJun 22, 2021
@plamut
Copy link
Contributor

Thanks for this!

As mentioned in the chat, it's fine for now and we can wait for the proper fix. But if the latter gets significantly delayed for some reason, we'll use this one as a workaround.

@dandhlee
Copy link
ContributorAuthor

googleapis/sphinx-docfx-yaml#55 is ready for review, once that's submitted and released it should be good! Hopefully it won't take too long.

plamut reacted with thumbs up emoji

@jimfultonjimfulton merged commit5e9494e intomasterJun 24, 2021
@jimfultonjimfulton deleted the dandhlee-patch-1 branchJune 24, 2021 12:08
dandhlee added a commit that referenced this pull requestJun 24, 2021
jimfulton pushed a commit that referenced this pull requestJun 24, 2021
emkornfield pushed a commit to emkornfield/python-bigquery that referenced this pull requestFeb 11, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stephaniewang526stephaniewang526Awaiting requested review from stephaniewang526

1 more reviewer

@jimfultonjimfultonjimfulton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dandhlee@plamut@jimfulton
[8]ページ先頭
©2009-2025 Movatter.jp