Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs(bigquery): Add alternative approach to setting credentials#517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
plamut merged 3 commits intogoogleapis:masterfromalanyee:patch-1
Feb 19, 2021
Merged

Conversation

@alanyee
Copy link
Contributor

@alanyeealanyee commentedFeb 10, 2021
edited
Loading

Add alternative approach to setting credentials in bigquery in the comments

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@alanyeealanyee requested a review froma team as acode ownerFebruary 10, 2021 23:21
@alanyeealanyee requested review frombusunkim96 and removed request fora teamFebruary 10, 2021 23:21
@google-clagoogle-clabot added the cla: yesThis human has signed the Contributor License Agreement. labelFeb 10, 2021
@product-auto-labelproduct-auto-labelbot added the api: bigqueryIssues related to the googleapis/python-bigquery API. labelFeb 10, 2021
@plamut
Copy link
Contributor

@anguillanneuf Since this is an addition to one of the snippets, could have a quick look at it? Thanks!

)

# Alternatively, use service_account.Credentials.from_service_account_info()
# to set credentials from a json string rather than read from a file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It's not actually a string, though, right? I thought the "info" function takes a parsed value (dictionary).

alanyee reacted with thumbs up emoji
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Right. I will correct that

Copy link
Contributor

@tswasttswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Thanks!

@tswasttswast added automergeMerge the pull request once unit tests and other checks pass. kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsFeb 18, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelFeb 18, 2021
@tswast
Copy link
Contributor

Lint is failing:

nox > flake8 docs/samplesdocs/samples/snippets/authenticate_service_account.py:33:81: W291 trailing whitespacenox > Command flake8 docs/samples failed with exit code 1

@plamutplamut added the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelFeb 18, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelFeb 18, 2021
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here:https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-greengcf-merge-on-greenbot removed the automergeMerge the pull request once unit tests and other checks pass. labelFeb 19, 2021
@plamutplamut merged commit60fbf28 intogoogleapis:masterFeb 19, 2021
@alanyeealanyee deleted the patch-1 branchFebruary 19, 2021 19:51
gcf-merge-on-greenbot pushed a commit that referenced this pull requestFeb 25, 2021
🤖 I have created a release \*beep\* \*boop\* ---## [2.10.0](https://www.github.com/googleapis/python-bigquery/compare/v2.9.0...v2.10.0) (2021-02-25)### Features* add BIGNUMERIC support ([#527](https://www.github.com/googleapis/python-bigquery/issues/527)) ([cc3394f](https://www.github.com/googleapis/python-bigquery/commit/cc3394f80934419eb00c2029bb81c92a696e7d88))### Bug Fixes* error using empty array of structs parameter ([#474](https://www.github.com/googleapis/python-bigquery/issues/474)) ([c1d15f4](https://www.github.com/googleapis/python-bigquery/commit/c1d15f4e5da4b7e10c00afffd59a5c7f3ded027a))* QueryJob.exception() *returns* the errors, not raises them ([#467](https://www.github.com/googleapis/python-bigquery/issues/467)) ([d763279](https://www.github.com/googleapis/python-bigquery/commit/d7632799769248b09a8558ba18f5025ebdd9675a))### Documentation* **bigquery:** Add alternative approach to setting credentials ([#517](https://www.github.com/googleapis/python-bigquery/issues/517)) ([60fbf28](https://www.github.com/googleapis/python-bigquery/commit/60fbf287b0d34d5db2e61cce7a5b42735ed43d0e))* explain retry behavior for DONE jobs ([#532](https://www.github.com/googleapis/python-bigquery/issues/532)) ([696c443](https://www.github.com/googleapis/python-bigquery/commit/696c443f0a6740be0767e12b706a7771bc1460c3))---This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tswasttswasttswast approved these changes

@busunkim96busunkim96Awaiting requested review from busunkim96

@anguillanneufanguillanneufAwaiting requested review from anguillanneuf

+1 more reviewer

@plamutplamutplamut left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alanyee@plamut@tswast@yoshi-kokoro

[8]ページ先頭

©2009-2025 Movatter.jp