- Notifications
You must be signed in to change notification settings - Fork322
fix(dbapi): allow rows to be fetched from scripts#387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
gcf-merge-on-green merged 1 commit intogoogleapis:masterfromtswast:issue377-dbapi-scriptingNov 12, 2020
Merged
fix(dbapi): allow rows to be fetched from scripts#387
gcf-merge-on-green merged 1 commit intogoogleapis:masterfromtswast:issue377-dbapi-scriptingNov 12, 2020
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
shollyman approved these changesNov 12, 2020
Contributor
shollyman left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice!
Contributor
mistercrunch commentedNov 13, 2020
|
Contributor
mistercrunch commentedDec 3, 2020
Big thanks for making this happen, this enabled us to ship this:apache/superset#11904 We're planning more work around creating a great experience around BigQuery in Superset, looking forward to more collaboration! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
api: bigqueryIssues related to the googleapis/python-bigquery API. cla: yesThis human has signed the Contributor License Agreement.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
is_dmllogic is not needed now that we moved togetQueryResultsinstead oftabledata.list(#375).Previously, the destination table of a DML query would return a non-null value that was unreadable or would return nonsense with DML (and some DDL) queries.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Towards#377 🦕