Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: Prepare for 2.0 release#278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
crwilcox merged 22 commits intogoogleapis:masterfromplamut:prepare-for-2-0
Sep 30, 2020

Conversation

@plamut
Copy link
Contributor

@plamutplamut commentedSep 25, 2020•
edited
Loading

This PR should serve as a preview of the 2.0 release.

For a start, the BQ Storagev1beta1 compatibility code is removed, as it will not be needed anymore once BQ Storage v2.0.0 is released.

TODO list:

  • Fix import paths in tests and samples that are affected bybigquery_v2 changes.
  • Describebigquery_v2 changes in UPGRADING guide.
  • Fix docs, includebigquery_v2 in them, if necessary.

@google-clagoogle-clabot added the cla: yesThis human has signed the Contributor License Agreement. labelSep 25, 2020
@product-auto-labelproduct-auto-labelbot added the api: bigqueryIssues related to the googleapis/python-bigquery API. labelSep 26, 2020
@plamutplamut added the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelSep 29, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelSep 29, 2020
@plamut
Copy link
ContributorAuthor

BQ Storage 2.0.0 released, re-running.

@plamut
Copy link
ContributorAuthor

FWIW, the snippets tests insamples/snippets fail because the generated noxfile tries to install BigQuery v1.x, but the snippets require v2.0.0 that is still in the making. They pass locally ifINSTALL_LIBRARY_FROM_SOURCE env variable is set and the following patch is applied:

diff --git samples/snippets/noxfile.py samples/snippets/noxfile.pyindex 5660f08..66589f5 100644--- samples/snippets/noxfile.py+++ samples/snippets/noxfile.py@@ -158,14 +158,17 @@ def _session_tests(session, post_install=None):         session.install("-r", "requirements-test.txt")      if INSTALL_LIBRARY_FROM_SOURCE:-        session.install("-e", _get_repo_root())+        session.install("-e", _get_repo_root() + "[all]")      if post_install:         post_install(session)diff --git samples/snippets/requirements.txt samples/snippets/requirements.txtindex 7fe8391..4753c47 100644--- samples/snippets/requirements.txt+++ samples/snippets/requirements.txt@@ -1,4 +1,4 @@-google-cloud-bigquery[pandas,bqstorage,pyarrow]==1.26.1+# google-cloud-bigquery[pandas,bqstorage,pyarrow]==1.26.1 google-auth-oauthlib==0.4.1 ipython==7.16.1; python_version < '3.7' ipython==7.17.0; python_version >= '3.7'

@tswast
Copy link
Contributor

They pass locally if INSTALL_LIBRARY_FROM_SOURCE env variable is set and the following patch is applied:

Do we need to add the necessary extras torequirements.txt?

The assertion seems to fail for a banal reason, i.e. an extra newlinein the string representation.
@tswast
Copy link
Contributor

Since it looks likerequirements.txt is used to install packages, even whenINSTALL_LIBRARY_FROM_SOURCE is set, I'm a bit confused as to why pandas isn't getting installed.

session.install("-r","requirements.txt")

Maybe I missed some logic that filters outgoogle-cloud-bigquery[pandas,...] from that installation?

@plamut
Copy link
ContributorAuthor

plamut commentedSep 30, 2020•
edited
Loading

@tswast Ah, I think that's probably because I temporarily commented out thegoogle-cloud-python line fromrequirements.txt completely, I just wanted to test with a local version of the library.

(and then had to adjust the installation from source line in noxfile to actually get all those extras installed)

@plamutplamut marked this pull request as ready for reviewSeptember 30, 2020 17:36
@plamutplamut requested a review froma teamSeptember 30, 2020 17:36
@plamutplamut requested a review froma team as acode ownerSeptember 30, 2020 17:36
There are currently no public API endpoints for the ModelServiceClient,thus there is no point in generating that code in the first place.
@crwilcox
Copy link
Contributor

Hammer merging to work around sample tests.

@crwilcoxcrwilcox merged commitcbcb4b8 intogoogleapis:masterSep 30, 2020
@plamut
Copy link
ContributorAuthor

@crwilcox Thanks!

Release PR (#284) will probably need the same hammer love.

@plamutplamut deleted the prepare-for-2-0 branchSeptember 30, 2020 22:52
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tswasttswasttswast approved these changes

@dinagravesdinagravesAwaiting requested review from dinagraves

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@plamut@tswast@crwilcox@yoshi-kokoro
[8]ページ先頭
©2009-2025 Movatter.jp