- Notifications
You must be signed in to change notification settings - Fork321
setdb.query.text OpenTelemetry attribute#2061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View thisfailed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| TEST_SPAN_ATTRIBUTES= {"foo":"baz"} | ||
| @pytest.mark.skipif(opentelemetryisNone,reason="Require `opentelemetry`") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's not possible to add marks to fixtures, this was wrong.
| query=getattr(job_ref,"query",None) | ||
| ifqueryisnotNone: | ||
| job_attributes["db.query.text"]=query |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
"query" is only available when the job is aQueryJob.
Kludex commentedNov 15, 2024
I've signed CLA. |
db.query.text OpenTelemetry attributedb.query.text OpenTelemetry attributesamuelcolvin commentedAug 29, 2025
PLEASE can we get this merged! |
Uh oh!
There was an error while loading.Please reload this page.
db.query.textattribute to the spans? #2042