- Notifications
You must be signed in to change notification settings - Fork321
fix: avoid blocking in download thread when using BQ Storage API#2034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
fix: avoid blocking in download thread when using BQ Storage API#2034
Uh oh!
There was an error while loading.Please reload this page.
Conversation
256b0f7 to3f8bd10Comparekien-truong commentedOct 24, 2024
Just dropping by to see if there's any concerns about this PR. |
This prevents a deadlock between the main thead and download threadswhen the threadpool is shutdown prematurely.
d3f2f1e to8eebb9dComparechalmerlowe commentedNov 18, 2024
I took a quick look. |
kien-truong commentedNov 18, 2024
The So, I just put a
|
tswast commentedFeb 3, 2025
Looks like cover is passing. |
54c8d07 intogoogleapis:mainUh oh!
There was an error while loading.Please reload this page.
tswast commentedFeb 4, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
After sleeping on this, I do think it's important to try and cover the currently uncovered branch. I'll see what I can do in a follow-up PR today. Edit: mailed#2127 |
This prevents a deadlock between the main thead and download threads when the threadpool is shutdown prematurely.
Fixes#2032 🦕