- Notifications
You must be signed in to change notification settings - Fork321
feat: usebigquery-magics package for the%%bigquery magic#1965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
chalmerlowe left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. One minor QUESTION/PREFERENCE.
Approving.
samples/magics/noxfile_config.py Outdated
| # TODO: Enable 3.10 once there is a geopandas/fiona release. | ||
| # https://github.com/Toblerity/Fiona/issues/1043 | ||
| "3.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
QUESTION/PREFERENCE:
This issue appears to be closed. I am not clear on what release we need to see from Fiona. This issue was closed on Nov 21, 2021.
They currently claim to require 3.8 and above.
If it is not an issue, I recommend we remove this statement.
| # TODO: Enable 3.10 once there is a geopandas/fiona release. | |
| # https://github.com/Toblerity/Fiona/issues/1043 | |
| "3.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good catch.
Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
Uh oh!
There was an error while loading.Please reload this page.
Deprecates version of
%%bigquerymagic in this package.Note: I keep the implementation intact to reduce disruption for folks that don't install the
ipythonextras.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixesgoogleapis/python-bigquery-magics#14
🦕