Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: usebigquery-magics package for the%%bigquery magic#1965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tswast merged 4 commits intomainfromtswast-bigquery-magics
Jul 10, 2024

Conversation

@tswast
Copy link
Contributor

@tswasttswast commentedJun 27, 2024
edited
Loading

Deprecates version of%%bigquery magic in this package.

Note: I keep the implementation intact to reduce disruption for folks that don't install theipython extras.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixesgoogleapis/python-bigquery-magics#14
🦕

@tswasttswast requested review froma team ascode ownersJune 27, 2024 21:03
@product-auto-labelproduct-auto-labelbot added the size: lPull request size is large. labelJun 27, 2024
@product-auto-labelproduct-auto-labelbot added the api: bigqueryIssues related to the googleapis/python-bigquery API. labelJun 27, 2024
Copy link
Collaborator

@chalmerlowechalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. One minor QUESTION/PREFERENCE.

Approving.

Comment on lines 27 to 29
# TODO: Enable 3.10 once there is a geopandas/fiona release.
# https://github.com/Toblerity/Fiona/issues/1043
"3.10",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

QUESTION/PREFERENCE:
This issue appears to be closed. I am not clear on what release we need to see from Fiona. This issue was closed on Nov 21, 2021.
They currently claim to require 3.8 and above.
If it is not an issue, I recommend we remove this statement.

Suggested change
# TODO: Enable 3.10 once there is a geopandas/fiona release.
# https://github.com/Toblerity/Fiona/issues/1043
"3.10",

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good catch.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chalmerlowechalmerlowechalmerlowe approved these changes

@engelkeengelkeAwaiting requested review from engelkeengelke is a code owner automatically assigned from googleapis/python-samples-owners

Assignees

@chalmerlowechalmerlowe

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: lPull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

update google-cloud-bigquery to usebigquery_magics package

3 participants

@tswast@chalmerlowe@obada-ab

[8]ページ先頭

©2009-2025 Movatter.jp