Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: addfields parameter toset_iam_policy for consistency with update methods#1872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tswast merged 2 commits intomainfromissue1871-get_iam_policy-set_iam_policy
Mar 27, 2024

Conversation

@tswast
Copy link
Contributor

@tswasttswast commentedMar 26, 2024•
edited
Loading

Also:

  • Add docstrings forget_iam_policy andset_iam_policy
  • Add code sample forget_iam_policy andset_iam_policy

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#1871 🦕

@tswasttswast requested review froma team ascode ownersMarch 26, 2024 15:46
@snippet-bot
Copy link

snippet-botbot commentedMar 26, 2024•
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated bysnippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, addsnippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-labelproduct-auto-labelbot added size: mPull request size is medium. api: bigqueryIssues related to the googleapis/python-bigquery API. labelsMar 26, 2024
@tswasttswast requested a review fromLinchinMarch 26, 2024 15:46
deftest_create_iam_policy(table_id:str):
your_table_id=table_id

# [START bigquery_create_iam_policy]
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

got_rows=self._fetch_single_page(dest_table)
self.assertTrue(len(got_rows)>0)

deftest_get_set_iam_policy(self):
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This test is now redundant with a code sample which serves the same purpose with regards to testing.

Copy link
Collaborator

@chalmerlowechalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@tswasttswastenabled auto-merge (squash)March 27, 2024 14:59
@tswasttswast merged commit08b1e6f intomainMar 27, 2024
@tswasttswast deleted the issue1871-get_iam_policy-set_iam_policy branchMarch 27, 2024 15:28
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chalmerlowechalmerlowechalmerlowe approved these changes

@farhan0102farhan0102Awaiting requested review from farhan0102farhan0102 was automatically assigned from googleapis/api-bigquery

@engelkeengelkeAwaiting requested review from engelkeengelke is a code owner automatically assigned from googleapis/python-samples-owners

@LinchinLinchinAwaiting requested review from Linchin

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

get_iam_policy and set_iam_policy are missing doc strings

2 participants

@tswast@chalmerlowe
[8]ページ先頭
©2009-2025 Movatter.jp