Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: Deserializing JSON subfields within structs fails#1742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gcf-merge-on-green merged 13 commits intogoogleapis:mainfromericapetersson:main
Dec 14, 2023

Conversation

@ericapetersson
Copy link
Contributor

@ericapeterssonericapetersson commentedDec 4, 2023•
edited
Loading

… for deserializing json subfields from bigquery, this adds support for that.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1500 🦕

ivan-toriya-precis reacted with hooray emoji
… for dezerialising json structures from bigquery, this adds support for that
@product-auto-labelproduct-auto-labelbot added size: xsPull request size is extra small. api: bigqueryIssues related to the googleapis/python-bigquery API. labelsDec 4, 2023
@product-auto-labelproduct-auto-labelbot added size: sPull request size is small. and removed size: xsPull request size is extra small. labelsDec 4, 2023
@LinchinLinchin added the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelDec 5, 2023
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelDec 5, 2023
@parthea
Copy link
Contributor

@ericapetersson, Thanks for opening a PR! Please could you add tests to close the coverage gap?

Name                                                         Stmts   Miss Branch BrPart  Cover   Missing--------------------------------------------------------------------------------------------------------google/cloud/bigquery/_helpers.py                              296      3    154      0    99%   244-247

@partheaparthea changed the titlefix(Adding-support-to-deserializing-json): currently there's no support…fix: Deserializing JSON subfields within structs failsDec 8, 2023
@partheaparthea added kokoro:runAdd this label to force Kokoro to re-run the tests. kokoro:force-runAdd this label to force Kokoro to re-run the tests. owlbot:runAdd this label to trigger the Owlbot post processor. labelsDec 8, 2023
@gcf-owl-botgcf-owl-botbot removed the owlbot:runAdd this label to trigger the Owlbot post processor. labelDec 8, 2023
@partheaparthea requested a review fromLinchinDecember 8, 2023 15:11
@yoshi-kokoroyoshi-kokoro removed kokoro:runAdd this label to force Kokoro to re-run the tests. kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsDec 8, 2023
@partheaparthea added kokoro:force-runAdd this label to force Kokoro to re-run the tests. owlbot:runAdd this label to trigger the Owlbot post processor. labelsDec 8, 2023
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelDec 8, 2023
@gcf-owl-botgcf-owl-botbot removed the owlbot:runAdd this label to trigger the Owlbot post processor. labelDec 8, 2023
@LinchinLinchin added the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelDec 13, 2023
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelDec 13, 2023
@tswast
Copy link
Contributor

Thanks so much for the contribution@ericapetersson ! This fix has been merged in#1587

@tswasttswast added kokoro:runAdd this label to force Kokoro to re-run the tests. automergeMerge the pull request once unit tests and other checks pass. owlbot:runAdd this label to trigger the Owlbot post processor. labelsDec 14, 2023
@gcf-owl-botgcf-owl-botbot removed the owlbot:runAdd this label to trigger the Owlbot post processor. labelDec 14, 2023
@yoshi-kokoroyoshi-kokoro removed the kokoro:runAdd this label to force Kokoro to re-run the tests. labelDec 14, 2023
@gcf-merge-on-greengcf-merge-on-greenbot merged commit0d93073 intogoogleapis:mainDec 14, 2023
@gcf-merge-on-greengcf-merge-on-greenbot removed the automergeMerge the pull request once unit tests and other checks pass. labelDec 14, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tswasttswasttswast approved these changes

@mrfaizalmrfaizalAwaiting requested review from mrfaizalmrfaizal was automatically assigned from googleapis/api-bigquery

@LinchinLinchinAwaiting requested review from Linchin

Assignees

@LinchinLinchin

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ericapetersson@parthea@tswast@Linchin@yoshi-kokoro
[8]ページ先頭
©2009-2025 Movatter.jp