Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: we can pass extra json.dumps args when using load_table_from_json#1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
HCA97 wants to merge7 commits intogoogleapis:main
base:main
Choose a base branch
Loading
fromHCA97:main

Conversation

@HCA97
Copy link

@HCA97HCA97 commentedAug 7, 2023•
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#1564 🦕

zheplusplus reacted with thumbs up emoji
@HCA97HCA97 requested review froma team ascode ownersAugust 7, 2023 20:12
@HCA97HCA97 requested a review fromtswastAugust 7, 2023 20:12
@product-auto-labelproduct-auto-labelbot added the size: mPull request size is medium. labelAug 7, 2023
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcfbot commentedAug 7, 2023•
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or useautomerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-labelproduct-auto-labelbot added the api: bigqueryIssues related to the googleapis/python-bigquery API. labelAug 7, 2023
@HCA97HCA97 changed the titlewe can pass extrajson.dumps args when usingload_table_from_jsonwe can pass extra json.dumps args when using load_table_from_jsonAug 7, 2023
@partheaparthea added kokoro:runAdd this label to force Kokoro to re-run the tests. kokoro:force-runAdd this label to force Kokoro to re-run the tests. owlbot:runAdd this label to trigger the Owlbot post processor. labelsAug 8, 2023
@gcf-owl-botgcf-owl-botbot removed the owlbot:runAdd this label to trigger the Owlbot post processor. labelAug 8, 2023
@yoshi-kokoroyoshi-kokoro removed kokoro:runAdd this label to force Kokoro to re-run the tests. kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsAug 8, 2023
@partheaparthea added kokoro:runAdd this label to force Kokoro to re-run the tests. kokoro:force-runAdd this label to force Kokoro to re-run the tests. owlbot:runAdd this label to trigger the Owlbot post processor. labelsAug 8, 2023
@gcf-owl-botgcf-owl-botbot removed the owlbot:runAdd this label to trigger the Owlbot post processor. labelAug 8, 2023
@yoshi-kokoroyoshi-kokoro removed kokoro:runAdd this label to force Kokoro to re-run the tests. kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsAug 8, 2023
@HCA97
Copy link
Author

HCA97 commentedAug 8, 2023•
edited
Loading

Hi@parthea, Kokoro Action failed because code coverage wasn't %100. I added the case whenjson.dump fails to parse.

@HCA97HCA97 changed the titlewe can pass extra json.dumps args when using load_table_from_jsonfeat: we can pass extra json.dumps args when using load_table_from_jsonAug 10, 2023
@partheaparthea added kokoro:runAdd this label to force Kokoro to re-run the tests. kokoro:force-runAdd this label to force Kokoro to re-run the tests. owlbot:runAdd this label to trigger the Owlbot post processor. labelsAug 30, 2023
@gcf-owl-botgcf-owl-botbot removed the owlbot:runAdd this label to trigger the Owlbot post processor. labelAug 30, 2023
@yoshi-kokoroyoshi-kokoro removed kokoro:runAdd this label to force Kokoro to re-run the tests. kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsAug 30, 2023
@tswasttswast requested review fromchalmerlowe and removed request fortswastOctober 4, 2023 16:23
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chalmerlowechalmerloweAwaiting requested review from chalmerlowe

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Provide json.dumps kwargs to load_table_from_json

3 participants

@HCA97@parthea@yoshi-kokoro
[8]ページ先頭
©2009-2025 Movatter.jp