Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs(bigquery): consistent use of optional keyword#153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@HemangChothani
Copy link
Contributor

Fixes#152

@googlebotgooglebot added the cla: yesThis human has signed the Contributor License Agreement. labelJun 30, 2020
Copy link
Contributor

@plamutplamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks really good, thanks for addressing this!

Found just a few things (capitalization, usages of Optional), and once fixed we can merge this IMO.

@HemangChothaniHemangChothani merged commit79d8c61 intogoogleapis:masterJun 30, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@plamutplamutplamut approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bigquery: Make consistent use of 'Optional' keyword in docstring

3 participants

@HemangChothani@plamut@googlebot
[8]ページ先頭
©2009-2025 Movatter.jp