Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: remove code generation for BQML proto files#1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
parthea merged 7 commits intomainfromtswast-patch-2
Dec 14, 2022

Conversation

@tswast
Copy link
Contributor

@tswasttswast commentedJul 19, 2022
edited
Loading

Some context around this PR:

These proto files are no longer used in the main client library. They only exist to assist in migration for packages that need to support google-cloud-bigquery 2.x and 3.x. Instead, a dictionary of the REST resource is exposed for the BQML-related statistics. This choice was made for a few reasons:

  • The backend team rarely publishes the updates they make to these protos tohttps://github.com/googleapis/googleapis/tree/master/google/cloud/bigquery Instead, historically the client libraries team has had to manually update them.
  • Sometimes the BQML team makes (unintentional?) breaking changes to the proto definitions. Since these protos are only manually updated, those breaking changes are only caught much later.
  • The proto files are only used by the Python client library, not any of the other client libraries.
  • The proto files only include a small subset of the BigQuery v2 interface.
  • The presence of these proto files occasionally confuses members of the backend team into thinking the BigQuery v2 API supports gRPC and/or GAPIC client library generation.

Resources

Towards#814

@tswasttswast requested a review froma teamJuly 19, 2022 18:39
@tswasttswast requested a review froma team as acode ownerJuly 19, 2022 18:39
@tswasttswast requested a review fromprash-miJuly 19, 2022 18:39
@product-auto-labelproduct-auto-labelbot added size: sPull request size is small. api: bigqueryIssues related to the googleapis/python-bigquery API. labelsJul 19, 2022
@tswast
Copy link
ContributorAuthor

@tswasttswast requested a review frompartheaJuly 20, 2022 21:07
@partheaparthea self-assigned thisAug 12, 2022
@tswasttswast added the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelAug 15, 2022
@tswasttswast closed thisAug 15, 2022
@tswasttswast reopened thisAug 15, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelSep 6, 2022
@aribrayaribray added the owlbot:runAdd this label to trigger the Owlbot post processor. labelNov 15, 2022
@gcf-owl-botgcf-owl-botbot removed the owlbot:runAdd this label to trigger the Owlbot post processor. labelNov 15, 2022
@product-auto-labelproduct-auto-labelbot added size: xsPull request size is extra small. and removed size: sPull request size is small. labelsNov 18, 2022
@partheapartheaenabled auto-merge (squash)December 14, 2022 16:25
@partheaparthea merged commitb8502a6 intomainDec 14, 2022
@partheaparthea deleted the tswast-patch-2 branchDecember 14, 2022 16:49
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull requestApr 17, 2023
* chore: remove code generation for BQML proto files* remove protos from owlbot configCo-authored-by: Anthonios Partheniou <partheniou@google.com>Co-authored-by: aribray <45905583+aribray@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@partheapartheaparthea approved these changes

@prash-miprash-miAwaiting requested review from prash-mi

Assignees

@partheaparthea

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: xsPull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tswast@parthea@yoshi-kokoro@aribray

[8]ページ先頭

©2009-2025 Movatter.jp