- Notifications
You must be signed in to change notification settings - Fork321
chore: sync main into v3 branch#1109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[](https://renovatebot.com)This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---|| [google-api-core](https://togithub.com/googleapis/python-api-core) | `==2.3.0` -> `==2.3.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) || [importlib-metadata](https://togithub.com/python/importlib_metadata) | `==4.8.2` -> `==4.8.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) |---### Release Notes<details><summary>googleapis/python-api-core</summary>### [`v2.3.2`](https://togithub.com/googleapis/python-api-core/releases/v2.3.2)[Compare Source](https://togithub.com/googleapis/python-api-core/compare/v2.3.1...v2.3.2)##### Bug Fixes- fix: exclude function target from retry deadline exceeded exception message ([#​318](https://www.togithub.com/googleapis/python-api-core/issues/318)) ([34ebdcc](https://togithub.com/googleapis/python-api-core/commit/34ebdcc251d4f3d7d496e8e0b78847645a06650b))### [`v2.3.1`](https://togithub.com/googleapis/python-api-core/compare/v2.3.0...v2.3.1)[Compare Source](https://togithub.com/googleapis/python-api-core/compare/v2.3.0...v2.3.1)</details><details><summary>python/importlib_metadata</summary>### [`v4.8.3`](https://togithub.com/python/importlib_metadata/blob/HEAD/CHANGES.rst#v483)[Compare Source](https://togithub.com/python/importlib_metadata/compare/v4.8.2...v4.8.3)\======- [#​357](https://togithub.com/python/importlib_metadata/issues/357): Fixed requirement generation from egg-info when a URL requirement is given.</details>---### Configuration📅 **Schedule**: At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.---This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-bigquery).
%5d(https%3a%2f%2frenovatebot.com){kind=link}
* chore(deps): update all dependencies* don't directly depend on cachetools* remove importlib metadata as direct dependency* remove zipp which comes from transitive dependencyCo-authored-by: Tim Swast <swast@google.com>
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea- [ ] Ensure the tests and linter pass- [ ] Code coverage does not decrease (if any source code was changed)- [x] Appropriate docs were updated (if necessary)Fixes #<issue_number_goes_here> 🦕To match the Trove classifiers on PyPI:https://pypi.org/project/google-cloud-bigquery/
Source-Link:googleapis/synthtool@52aef91Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:36a95b8f494e4674dc9eee9af98961293b51b86b3649942aac800ae6c1f796d4Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…essage` instead (#1105)Since query text can potentially contain sensitive information, remove it fromthe default exception message. This information is useful for debugging, soprovide a `debug_message` attribute, which is not included in the exceptionrepresentation (and thus the logs).Fixes internal issue 211616590
🤖 I have created a release *beep* *boop*---## [2.32.0](v2.31.0...v2.32.0) (2022-01-12)### Features* support authorized dataset entity ([#1075](#1075)) ([c098cd0](c098cd0))### Bug Fixes* remove query text from exception message, use `exception.debug_message` instead ([#1105](#1105)) ([e23114c](e23114c))---This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ContributorAuthor
tswast commentedJan 13, 2022
Marking "do not merge" as a reminder to use a merge commit. Ready for review. No conflicts this time except in |
ContributorAuthor
tswast commentedJan 13, 2022
Filed#1110 for test failures. I believe it was caused by the refactor ingoogleapis/python-bigquery-storage#366 System tests are passing, so I think it's just an issue with how we're mocking in the unit tests. |
* chore(deps): update all dependencies* test: limit deps versions by python* remove pyproj, as it is only a transitive dependencyCo-authored-by: Tim Swast <swast@google.com>Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Source-Link:googleapis/synthtool@69fda12Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ae600f36b6bc972b368367b6f83a1d91ec2c82a4a116b383d67d547c56fe6de3Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>Co-authored-by: Tim Swast <swast@google.com>
plamut approved these changesJan 17, 2022
* fix: Make gc check resilient to broken weakrefsIn some python deployments (I believe macOS is one), weakref objects aren't guaranteed to exist across gc collections. The proposed check pattern is also used in tensorflow [0] which ran into similar issues a few years ago.[0]:https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/framework/errors_test.py#L33* fix: add pragma for coverage* Fix whitespace
)Source-Link:googleapis/synthtool@4760d8dPost-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f0e4b51deef56bed74d3e2359c583fc104a8d6367da3984fc5c66938db738828Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
shollyman approved these changesJan 20, 2022
Contributor
shollyman left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I gave this a cursory scan given its nature as a merge, and my not having a lot of context on the branch delta currently. If you need me to take a deeper look let me know.
ContributorAuthor
tswast commentedJan 20, 2022
Thanks@shollyman . All of these commits have been reviewed at least once before, so a cursory look should be sufficient. The only conflicts I had to deal with were in some samples requirements.txt files. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
api: bigqueryIssues related to the googleapis/python-bigquery API. do not mergeIndicates a pull request not ready for merge, due to either quality or timing.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards#1021