- Notifications
You must be signed in to change notification settings - Fork321
chore: sync v3 with main branch#1088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
* feat: allow cell magic body to be a $variable* Fix missing indefinitive article in error msg* Adjust test assertion to error message change* Refactor logic for extracting query variable* Explicitly warn about missing query variable name* Thest the query "variable" is not identifier case
* feat: promote `to_arrow_iterable` to public method* use correct version number* Update google/cloud/bigquery/table.pyCo-authored-by: Tim Swast <swast@google.com>
* fix: apply timeout to all resumable upload requests* Fix stub in test case* Improve timeout type and other type annotations* Annnotate return type of _do_resumable_upload()
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
…taFrame (#1078)Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea- [ ] Ensure the tests and linter pass- [ ] Code coverage does not decrease (if any source code was changed)- [ ] Appropriate docs were updated (if necessary)Towards #1076 🦕(edit: moved togoogleapis/python-db-dtypes-pandas#45 )
* revoke dataset access setup* basic template for sample* sample + test* revoke dataset access sample* 🦉 Updates from OwlBotSeehttps://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md* docs: add sample for revoking dataset access - update year and string formatting* docs: add sample for revoking dataset access - move to snippets and change parameter pattern for readibility* moving update_dataset to /snippets and adjusting imports on both revoke_access and update_access* Update samples/snippets/revoke_dataset_access.pyremoved nested START/END tagsCo-authored-by: Tim Swast <swast@google.com>* Update samples/snippets/revoke_dataset_access.pyupdate readability in API requestCo-authored-by: Tim Swast <swast@google.com>* 🦉 Updates from OwlBotSeehttps://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md* updated test* 🦉 Updates from OwlBotSeehttps://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md* change after running test* resolving linting failure, rewriting test* removed relative import errors* remove relative mport from update_dataset_access* adding fixture to conftest.py* updated sample* updating sample to match new update_access sample* fixing region tags* consolidated tests into one file for both methods* updating test to full_dataset format* updated revoke sample* updating test* refactored sample* Update samples/snippets/conftest.py* Update samples/snippets/revoke_dataset_access.pyCo-authored-by: Tim Swast <swast@google.com>* Update samples/snippets/update_dataset_access.pyCo-authored-by: Tim Swast <swast@google.com>* Update samples/snippets/revoke_dataset_access.pyCo-authored-by: Tim Swast <swast@google.com>* Update samples/snippets/revoke_dataset_access.pyCo-authored-by: Tim Swast <swast@google.com>* refactoring entry* added comment for entry access* Update samples/snippets/README.rstCo-authored-by: Tim Swast <swast@google.com>* Update samples/snippets/dataset_access_test.pyCo-authored-by: Tim Swast <swast@google.com>* Update samples/snippets/dataset_access_test.pyCo-authored-by: Tim Swast <swast@google.com>* added develper TODO in sample* add comments to samplesCo-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>Co-authored-by: Tim Swast <swast@google.com>Co-authored-by: Peter Lamut <plamut@users.noreply.github.com>Co-authored-by: Anthonios Partheniou <partheniou@google.com>Co-authored-by: meredithslota <meredithslota@google.com>
* feat: support authorized dataset entity* cleanup* add test and cache the resource from from_api_repr in a _properties value* lint* update samples to use enums* update to_api_repr and add tests* refactor
* chore(deps): update all dependencies* exclude new geopandas from python 3.6Co-authored-by: Tim Swast <swast@google.com>
tswast commentedDec 15, 2021
tests/unit/test_table.py Outdated
| ) | ||
| @mock.patch("google.cloud.bigquery.table.pyarrow",new=None) | ||
| deftest_to_arrow_iterable_error_if_pyarrow_is_none(self): |
ContributorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oops. I think we can delete this now that pyarrow is a required dependency
ContributorAuthor
tswast commentedDec 15, 2021
Note: the diff is a bit smaller than expected because#1081 pulled some changes in from |
shollyman approved these changesDec 15, 2021
Contributor
shollyman left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, with the caveat that I have no real context on what's in/out of scope for the merge as I've not been following the v3 branch closely.
Contributor
plamut commentedDec 16, 2021
Everything from the |
plamut approved these changesDec 16, 2021
Contributor
plamut left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
The failures seem transient, a bunch of 500 errors.
Contributor
plamut commentedDec 16, 2021
Hm... the copy table test still consistently fails across all test runs. |
ContributorAuthor
tswast commentedDec 16, 2021
Seth filed internal issue 210907595 to get this fixed. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
"do not merge" label is just a reminder to use a merge commit