- Notifications
You must be signed in to change notification settings - Fork321
chore: sync v3 with main#1004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
* chore: protect v3.x.x branchIn preparation for breaking changes.* force pattern to be a string* simplify branch name
…#815)That warning should only be used when BQ Storage client isexplicitly passed in to RowIterator methods when max_resultsvalue is also set.
…ields for BQML. (#817)PiperOrigin-RevId: 387137741Source-Link:googleapis/googleapis@8962c92Source-Link:googleapis/googleapis-gen@102f1b4
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
These two lines bring the rules on this repo in line with the defaults:https://github.com/googleapis/repo-automation-bots/blob/63c858e539e1f4d9bb8ea66e12f9c0a0de5fef55/packages/sync-repo-settings/src/required-checks.json#L40-L50
The backend API has a timeout of 4 minutes, so the default of 2 minutes was notallowing for any retries to happen in some cases.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea- [ ] Ensure the tests and linter pass- [ ] Code coverage does not decrease (if any source code was changed)- [ ] Appropriate docs were updated (if necessary)Fixes#853 🦕
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>Co-authored-by: Tim Swast <swast@google.com>
[](https://renovatebot.com)This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---|| [google-cloud-bigquery](https://togithub.com/googleapis/python-bigquery) | `==2.23.2` -> `==2.23.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) |***### Release Notes<details><summary>googleapis/python-bigquery</summary>### [`v2.23.3`](https://togithub.com/googleapis/python-bigquery/blob/master/CHANGELOG.md#2233-httpswwwgithubcomgoogleapispython-bigquerycomparev2232v2233-2021-08-06)[Compare Source](https://togithub.com/googleapis/python-bigquery/compare/v2.23.2...v2.23.3)</details>***### Configuration📅 **Schedule**: At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this update again.**** \[ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.***This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-bigquery).
%5d(https%3a%2f%2frenovatebot.com){kind=link}
* feat: add support for transaction statistics* Hoist transaction_info into base job class* Add versionadded directive to new property and class* Include new class in docs reference
#863)[](https://renovatebot.com)This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---|| [google-cloud-bigquery-storage](https://togithub.com/googleapis/python-bigquery-storage) | `==2.6.2` -> `==2.6.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) |***### Release Notes<details><summary>googleapis/python-bigquery-storage</summary>### [`v2.6.3`](https://togithub.com/googleapis/python-bigquery-storage/blob/master/CHANGELOG.md#263-httpswwwgithubcomgoogleapispython-bigquery-storagecomparev262v263-2021-08-06)[Compare Source](https://togithub.com/googleapis/python-bigquery-storage/compare/v2.6.2...v2.6.3)</details>***### Configuration📅 **Schedule**: At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this update again.**** \[x] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.***This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-bigquery).
Source-Link:googleapis/synthtool@6252f2cPost-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:50e35228649c47b6ca82aa0be3ff9eb2afce51c82b66c4a03fe4afeb5ff6c0fcCo-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* feat: make the same Table instances equal to each other* Table equality should ignore metadata differences* Compare instances through tableReference property* Make Table instances hashable* Make Table* classes interchangeableIf these classes reference the same table, they are now considered equal.
…larQueryParameter` constructor (#850)Follow-up tohttps://github.com/googleapis/python-bigquery/pull/840/files#r679880582Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea- [ ] Ensure the tests and linter pass- [ ] Code coverage does not decrease (if any source code was changed)- [ ] Appropriate docs were updated (if necessary)
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:- [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea- [x] Ensure the tests and linter pass- [x] Code coverage does not decrease (if any source code was changed)- [x] Appropriate docs were updated (if necessary)Fixes#539 🦕Previously, we only retried failed API requests. Now, we retry failed jobs (according to the predicate of the `Retry` object passed to `job.result()`).
Co-authored-by: Tim Swast <swast@google.com>Co-authored-by: Tres Seaver <tseaver@palladion.com>
ContributorAuthor
tswast commentedOct 7, 2021
Samples 3.10 failure is expected. I might want to delete that job for now. |
Contributor
tseaver commentedOct 7, 2021
@tswast I think the change to the samples image isforthcoming soon. |
ContributorAuthor
tswast commentedOct 7, 2021
It's still going to fail for BQ, because we don't have wheels for many of our compiled dependencies. e.g. pandas, numpy, pyarrow. |
chore: fix docstring for first attribute of protoscommitter:@busunkim96PiperOrigin-RevId: 401271153Source-Link:googleapis/googleapis@787f8c9Source-Link:googleapis/googleapis-gen@81decffCopy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODFkZWNmZmU5ZmM3MjM5NmE4MTUzZTc1NmQxZDY3YTZlZWNmZDYyMCJ9* 🦉 Updates from OwlBotSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.mdCo-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>Co-authored-by: Tim Swast <swast@google.com>
_Thank_ you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea- [ ] Ensure the tests and linter pass- [ ] Code coverage does not decrease (if any source code was changed)- [ ] Appropriate docs were updated (if necessary)Fixes#995 🦕
ContributorAuthor
tswast commentedOct 12, 2021
We'll want to wait for allowing merge commits before we merge this:#1018 |
This should prevent conflicts when we sync v3 with main.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea- [ ] Ensure the tests and linter pass- [ ] Code coverage does not decrease (if any source code was changed)- [ ] Appropriate docs were updated (if necessary)
* feat: allow queryJob.result() to be called on a dryRun* update to return EmptyRowIterator
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea- [ ] Ensure the tests and linter pass- [ ] Code coverage does not decrease (if any source code was changed)- [ ] Appropriate docs were updated (if necessary)Issue discovered while investigating what properties are needed in#967
ContributorAuthor
tswast commentedOct 15, 2021
CC@plamut , I think for future syncs from main to v3 we should use merge commits. That seems to make it easier as I add commits from main to this PR. |
…1023)While implementing Sessions, I noticed several missing classes in the reference docs.Using "automodule" since experience has shown we often forget to add new classes to `docs/reference.rst`.
Contributor
plamut commentedOct 16, 2021
@tswast That's actually a very sensible idea, as I had the deja vu feeling when syncing the |
plamut suggested changesOct 16, 2021
Contributor
plamut left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It seems fine, apart from the intersphinx links that should be retained.
The unit tests still produce no warnings, and theskipif decorators in tests do not check for dependencies that have been made required inv3 (BQ storage, pyarrow...) - these are the two main things that can sneak in without a merge conflict, as far as I can remember.
Comment on lines -35 to -36
| "proto-plus": ("https://proto-plus-python.readthedocs.io/en/latest/",None), | ||
| "protobuf": ("https://googleapis.dev/python/protobuf/latest/",None), |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
IIRC these were added these ack when we re-added legacy proto-based types tov3. We should thus retain them.
Comment on lines -58 to -59
| # Remove unneeded intersphinx links, the library does not use any proto-generated code. | ||
| s.replace("docs/conf.py",r'\s+"(proto-plus|protobuf)":.*$',"") |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Related to the comment above, we actually want to include proto* intersphinx links.
ContributorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This line was actually removing them from the template. Deleting this line, we retain the ones fromhttps://github.com/googleapis/synthtool/blob/694118b039b09551fb5d445fceb361a7dbb06400/synthtool/gcp/templates/python_library/docs/conf.py.j2#L369-L370 and don't need to add them in theintersphinx_dependencies dictionary.
ContributorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Mailed#1035 to do this separately rather than as a merge frommain.
Contributor
plamut commentedOct 16, 2021
Added the |
#1030)Source-Link:googleapis/synthtool@7fd61f8Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:4ee57a76a176ede9087c14330c625a71553cf9c72828b2c0ca12f5338171ba60Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
plamut approved these changesOct 28, 2021
Contributor
plamut commentedOct 28, 2021
Used a merged commit, this should get rid of the ever-growing list of merge conflicts every time we sync |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
api: bigqueryIssues related to the googleapis/python-bigquery API. cla: yesThis human has signed the Contributor License Agreement.
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thought: maybe if we merge this as a merge commit, we can avoid some conflicts the next time we sync?