- Notifications
You must be signed in to change notification settings - Fork321
perf: cache first page ofjobs.getQueryResults rows#374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
steffnay merged 2 commits intogoogleapis:masterfromtswast:issue362-getQueryResults-cacheNov 10, 2020
Merged
perf: cache first page ofjobs.getQueryResults rows#374
steffnay merged 2 commits intogoogleapis:masterfromtswast:issue362-getQueryResults-cacheNov 10, 2020
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
tswast commentedNov 5, 2020
@busunkim96 Could you or another Yoshi take a look at this PR? It makes some modifications to an overridden |
steffnay approved these changesNov 10, 2020
Contributor
steffnay left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
busunkim96 approved these changesNov 10, 2020
tswast added a commit to tswast/python-bigquery that referenced this pull requestNov 24, 2020
When there are large result sets, fetching rows while waiting for thequery to finish can cause the API to hang indefinitely. (This may be dueto an interaction between connection timeout and API timeout.)This reverts commit86f6a51 (googleapis#374).
4 tasks
gcf-merge-on-greenbot pushed a commit that referenced this pull requestNov 24, 2020
When there are large result sets, fetching rows while waiting for thequery to finish can cause the API to hang indefinitely. (This may be dueto an interaction between connection timeout and API timeout.)This reverts commit86f6a51 (#374).Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:- [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea- [x] Ensure the tests and linter pass- [x] Code coverage does not decrease (if any source code was changed)- [x] Appropriate docs were updated (if necessary)Fixesgoogleapis/python-bigquery-pandas#343Fixes#394 🦕
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
api: bigqueryIssues related to the googleapis/python-bigquery API. cla: yesThis human has signed the Contributor License Agreement.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Replaces and simplifies#347 . The cache is only used if
max_results,page_size, andstart_indexare not set.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Towards#362 🦕