Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: table iterator should not use bqstorage when page_size is not None#2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
chelsea-lin merged 2 commits intomainfrommain_chelsealin_page_size
Apr 3, 2025

Conversation

@chelsea-lin
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@chelsea-linchelsea-lin requested a review fromtswastApril 2, 2025 23:16
@chelsea-linchelsea-lin requested review froma team ascode ownersApril 2, 2025 23:16
@product-auto-labelproduct-auto-labelbot added size: sPull request size is small. api: bigqueryIssues related to the googleapis/python-bigquery API. labelsApr 2, 2025
@chelsea-linchelsea-linforce-pushed themain_chelsealin_page_size branch from0cc6e45 to966cd28CompareApril 2, 2025 23:47
Copy link
Contributor

@tswasttswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@tswast
Copy link
Contributor

Looks like two tests are failing:

FAILED tests/unit/test_dbapi_cursor.py::TestCursor::test_fetchall_w_bqstorage_client_fetch_error_no_fallbackFAILED tests/unit/test_dbapi_cursor.py::TestCursor::test_fetchall_w_bqstorage_client_no_arrow_compression

I think we need to remove this logic:

ifsizeisNone:
# Since self.arraysize can be None (a deviation from PEP 249),
# use an actual PEP 249 default of 1 in such case (*some* number
# is needed here).
size=self.arraysizeifself.arraysizeelse1

Page size of 1 is going to be super slow, so I don't think we should be setting that if people explicitly request "None" as the page size.

chelsea-lin reacted with thumbs up emoji

@chelsea-linchelsea-linforce-pushed themain_chelsealin_page_size branch from966cd28 to33709b1CompareApril 3, 2025 18:22
@chelsea-linchelsea-lin merged commite89a707 intomainApr 3, 2025
18 checks passed
@chelsea-linchelsea-lin deleted the main_chelsealin_page_size branchApril 3, 2025 18:45
chelsea-lin added a commit that referenced this pull requestMay 19, 2025
Linchin pushed a commit that referenced this pull requestMay 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tswasttswasttswast approved these changes

Assignees

@leahecoleleahecole

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chelsea-lin@tswast@leahecole
[8]ページ先頭
©2009-2025 Movatter.jp