Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: support resource_tags for table#2093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Linchin merged 13 commits intogoogleapis:mainfromhrkh:feature/resource-tags
Jan 21, 2025

Conversation

@hrkh
Copy link
Contributor

@hrkhhrkh commentedDec 21, 2024•
edited
Loading

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#2089 🦕

@product-auto-labelproduct-auto-labelbot added size: mPull request size is medium. api: bigqueryIssues related to the googleapis/python-bigquery API. labelsDec 21, 2024
@hrkhhrkhforce-pushed thefeature/resource-tags branch from732426d toe783909CompareDecember 21, 2024 04:30
@hrkhhrkh changed the titleSupport resource_tags for Tablefeat: support resource_tags for tableDec 21, 2024
@hrkhhrkh marked this pull request as ready for reviewDecember 21, 2024 05:16
@hrkhhrkh requested review froma team ascode ownersDecember 21, 2024 05:16
@hrkhhrkh marked this pull request as draftDecember 21, 2024 06:42
@hrkhhrkh marked this pull request as ready for reviewDecember 21, 2024 10:58
@Linchin
Copy link
Contributor

Sorry, this seems to be a duplicate of#2090.

@LinchinLinchin closed thisJan 3, 2025
@hrkh
Copy link
ContributorAuthor

hrkh commentedJan 6, 2025

Hi@Linchin ,
Thank you for your feedback.

This PR was closed as a duplicate of#2090, but I’d like to clarify that#2090 addresses the resource tags for datasets, while this PR focuses on the resource tags for tables.

Could you please reopen this PR for further review? Let me know if additional clarification is needed.

@LinchinLinchin reopened thisJan 6, 2025
@Linchin
Copy link
Contributor

Thank you@hrkh for clarifying! I have reopened and will review this PR.

@LinchinLinchin added kokoro:runAdd this label to force Kokoro to re-run the tests. kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsJan 6, 2025
@yoshi-kokoroyoshi-kokoro removed kokoro:runAdd this label to force Kokoro to re-run the tests. kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsJan 6, 2025
@LinchinLinchin added kokoro:runAdd this label to force Kokoro to re-run the tests. kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsJan 16, 2025
@yoshi-kokoroyoshi-kokoro removed kokoro:runAdd this label to force Kokoro to re-run the tests. kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsJan 16, 2025
@Linchin
Copy link
Contributor

Thank you@hrkh for your contribution! It seems we just have the system test with python 3.12 failing, and it was caused by the same resource tag having been created by the python 3.8 system test. We encountered the exact same issue in#2090, and it was resolved by prefixing a randomly generated string to the tags (as inthis commit). Could you see if you could implement this, so we can get this PR across the line? Cheers.

@hrkh
Copy link
ContributorAuthor

Thank you@Linchin for your detailed feedback and guidance!

I've updated the PR to append randomly generated strings as suffixes to the tag keys, following the approach used in the referenced commit. This should resolve the test failures with Python 3.12.

Please let me know if any further adjustments are needed.

@LinchinLinchin added kokoro:runAdd this label to force Kokoro to re-run the tests. kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsJan 21, 2025
@LinchinLinchin added kokoro:runAdd this label to force Kokoro to re-run the tests. kokoro:force-runAdd this label to force Kokoro to re-run the tests. and removed kokoro:runAdd this label to force Kokoro to re-run the tests. kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsJan 21, 2025
@yoshi-kokoroyoshi-kokoro removed kokoro:runAdd this label to force Kokoro to re-run the tests. kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsJan 21, 2025
@LinchinLinchin added kokoro:runAdd this label to force Kokoro to re-run the tests. kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsJan 21, 2025
@yoshi-kokoroyoshi-kokoro removed kokoro:runAdd this label to force Kokoro to re-run the tests. kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsJan 21, 2025
Copy link
Contributor

@LinchinLinchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Thank you!

hrkh reacted with heart emoji
@LinchinLinchin merged commitd4070ca intogoogleapis:mainJan 21, 2025
16 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@LinchinLinchinLinchin approved these changes

@PhongChuongPhongChuongAwaiting requested review from PhongChuongPhongChuong was automatically assigned from googleapis/api-bigquery

Assignees

@LinchinLinchin

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support resource_tags for Table

3 participants

@hrkh@Linchin@yoshi-kokoro
[8]ページ先頭
©2009-2025 Movatter.jp