NotificationsYou must be signed in to change notification settings
Fork321
Star786

deps: bump min version of google-api-core and google-cloud-core to 2.x#1972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Linchin merged 1 commit intomainfromtswast-constraints

Jul 10, 2024

Merged

deps: bump min version of google-api-core and google-cloud-core to 2.x#1972

Linchin merged 1 commit intomainfromtswast-constraints

Jul 10, 2024

Conversation

Copy link

Contributor

tswast commentedJul 10, 2024

Fixes constraints file to match setup.py

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Towardsgoogleapis/python-aiplatform#4079 🦕

deps: bump min version of google-api-core and google-cloud-core to 2.x

fd8b49d

Fixes constraints file to match setup.py

tswast requested review froma team ascode owners

July 10, 2024 16:21

tswast requested a review fromchalmerlowe

July 10, 2024 16:21

blunderbuss-gcfbot assignedhongalex

Jul 10, 2024

product-auto-labelbot added size: s

Pull request size is small.

api: bigqueryIssues related to the googleapis/python-bigquery API. labels

Jul 10, 2024

Linchin approved these changes

Jul 10, 2024

View reviewed changes

Copy link

Contributor

Linchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you so much for fixing the issue so quickly!

For posterity, what is the process to update the required dependency versions?

Linchin merged commita958732 intomain

Jul 10, 2024

Linchin deleted the tswast-constraints branch

July 10, 2024 18:20

release-pleasebot mentioned this pull request

Jul 10, 2024

chore(main): release 3.26.0#1973

Merged

Copy link

ContributorAuthor

tswast commentedJul 10, 2024

For posterity, what is the process to update the required dependency versions?

@Linchin Main thing is that when updatingsetup.py, make sure to updateconstraints.txt for the minimum supported Python version. Note: the tests validate viaconstraints.txt, so if you find yourself wanting to update one of those, make sure you make the corresponding change insetup.py.

See:googleapis/gapic-generator-python#1788 for a hint at how this works in the generated clients as well asgoogleapis/synthtool#1901 to apply these minimum version constraints checks via the synthtool templated files.