NotificationsYou must be signed in to change notification settings
Fork321
Star786

feat: add prefer_bqstorage_client option for Connection#1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Linchin merged 1 commit intogoogleapis:mainfromLinchin:connection-option-1920

Jun 10, 2024

Merged

feat: add prefer_bqstorage_client option for Connection#1945

Linchin merged 1 commit intogoogleapis:mainfromLinchin:connection-option-1920

Jun 10, 2024

Conversation

Copy link

Contributor

Linchin commentedJun 4, 2024•
edited
Loading

This gives users the option to not use the Storage client if they prefer the REST client.

Fixes#1920 🦕

feat: add prefer_bqstorage_client option for Connection

1065464

Linchin assignedchalmerlowe

Jun 4, 2024

Linchin requested review froma team ascode owners

June 4, 2024 23:23

Linchin requested a review fromshollyman

June 4, 2024 23:23

product-auto-labelbot added size: m

Pull request size is medium.

api: bigqueryIssues related to the googleapis/python-bigquery API. labels

Jun 4, 2024

chalmerlowe approved these changes

Jun 10, 2024

View reviewed changes

Copy link

Collaborator

chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

QUESTION: Would we consider this a breaking change since we are moving to having a default setting ofTrue instead ofFalse which is what I feel like the current setting is.

I am approving this, pending an answer to the above question.
Would be happy to get in a chat OR a meeting to discuss, as need. be.

Copy link

ContributorAuthor

Linchin commentedJun 10, 2024

QUESTION: Would we consider this a breaking change since we are moving to having a default setting ofTrue instead ofFalse which is what I feel like the current setting is.
I am approving this, pending an answer to the above question. Would be happy to get in a chat OR a meeting to discuss, as need. be.

Thanks for the question! The default behavior in the past isTrue. As in#1920, the customer couldn't disable the storage client unless they uninstall the package altogether.