- Notifications
You must be signed in to change notification settings - Fork321
perf: decrease the threshold in which we use the BQ Storage Read API#1925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
google/cloud/bigquery/table.py Outdated
| # In microbenchmarks, the first full page will be about 10 MB. If a page is | ||
| # about 2 MB, then it's the same speed or faster to download all the results | ||
| # using the BigQuery Storage Read API. | ||
| ALMOST_COMPLETELY_CACHED_RATIO=10/ (10+2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not sure I'm following the comment. In usage this appears to be a row ratio, but the comment is about response wire sizes? Also, should the value just remain a float literal? There's no parameter plugging in here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Updated the comment to explain more my methodology. Unfortunately, this heuristic isn't perfect, as it breaks down with large rows.
shollyman left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the clarifications
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕