Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: creates linting-typing.cfg in presubmit#1881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
chalmerlowe merged 17 commits intomainfromadd-linting-typing-kokoro
Apr 3, 2024

Conversation

@chalmerlowe
Copy link
Collaborator

This PR creates a new configuration file in the.kokoro/presubmit folder.
The intent is to eventually move multiple checks out of the baselineKokoro check and put them into their ownKokoro linting-typing:

The checks we are moving out include:

Typing:

  • mypy
  • mypy_samples
  • pytype

Linting/formatting:

  • lint
  • lint_setup_py
  • blacken

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcfbot commentedMar 29, 2024•
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or useautomerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-labelproduct-auto-labelbot added size: xsPull request size is extra small. api: bigqueryIssues related to the googleapis/python-bigquery API. labelsMar 29, 2024
@product-auto-labelproduct-auto-labelbot added size: sPull request size is small. and removed size: xsPull request size is extra small. labelsMar 29, 2024
@chalmerlowe
Copy link
CollaboratorAuthor

chalmerlowe commentedMar 29, 2024•
edited
Loading

There is an internal Google CL (#618137967) to update the allowed env vars for this repository.
Once that gets approved, we should be able to confirm that this PR runs and determine what, if any time-savings are achieved by parallelizing these tests.

Copy link
Contributor

@shollymanshollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for simplifying this a bit!

@chalmerlowechalmerlowe added the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelMar 29, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelMar 29, 2024
Copy link
CollaboratorAuthor

@chalmerlowechalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

updated the comments.

@chalmerlowechalmerlowe added the kokoro:runAdd this label to force Kokoro to re-run the tests. labelApr 2, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:runAdd this label to force Kokoro to re-run the tests. labelApr 2, 2024
@chalmerlowechalmerlowe added the owlbot:runAdd this label to trigger the Owlbot post processor. labelApr 2, 2024
@gcf-owl-botgcf-owl-botbot removed the owlbot:runAdd this label to trigger the Owlbot post processor. labelApr 2, 2024
@chalmerlowechalmerlowe added the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelApr 2, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelApr 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@shollymanshollymanshollyman approved these changes

@PhongChuongPhongChuongAwaiting requested review from PhongChuongPhongChuong was automatically assigned from googleapis/api-bigquery

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chalmerlowe@shollyman@yoshi-kokoro
[8]ページ先頭
©2009-2025 Movatter.jp