NotificationsYou must be signed in to change notification settings
Fork321
Star786

fix:`query_and_wait` now retains unknown query configuration`_properties`#1793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

tswast merged 4 commits intomainfromissue1792-query_and_wait-invalid-job_config

Jan 23, 2024

Merged

fix:`query_and_wait` now retains unknown query configuration`_properties`#1793

tswast merged 4 commits intomainfromissue1792-query_and_wait-invalid-job_config

Jan 23, 2024

Conversation

Copy link

Contributor

tswast commentedJan 19, 2024•
edited
Loading

fix: raiseValueError inquery_and_wait with wrongjob_config type

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes#1792
🦕

fix:query_and_wait now retains unknown query configuration `_prope…

90b0d9e

…rties`

tswast requested review froma team ascode owners

January 19, 2024 17:20

tswast requested a review fromNeenu1995

January 19, 2024 17:20

product-auto-labelbot added size: m

Pull request size is medium.

api: bigqueryIssues related to the googleapis/python-bigquery API. labels

Jan 19, 2024

tswast changed the title~~fix:query_and_wait now retains unknown query configuration `_prope…~~fix:query_and_wait now retains unknown query configuration_properties

Jan 19, 2024

tswast requested a review fromLinchin

January 19, 2024 17:20

tswast mentioned this pull request

Jan 19, 2024

feat: use faster query_and_wait method from google-cloud-bigquery when availablegoogleapis/python-bigquery-pandas#722

Merged

4 tasks

fix: raiseValueError inquery_and_wait withjob_config type

97b02e1

tswastenabled auto-merge (squash)

January 19, 2024 20:26

Copy link

Contributor

Linchin commentedJan 19, 2024

Could you tell me more about the rationale of keeping unknown config fields?

Merge branch 'main' into issue1792-query_and_wait-invalid-job_config

112a8b2

Copy link

ContributorAuthor

tswast commentedJan 22, 2024

Could you tell me more about the rationale of keeping unknown config fields?

Two reasons: (1) as you can see from the removal of this code:

    # These keys are top level in job resource and query resource.    if "labels" in job_config_resource:        request_body["labels"] = job_config_resource["labels"]    if "dryRun" in job_config_resource:        request_body["dryRun"] = job_config_resource["dryRun"]

it allows for a cleaner conversion from query job insert request to jobs.query request.

(2) It allows for customers who want access to features that are in preview an not yet implemented in the client library to set REST API properties via settingQueryJobConfig._properties. This is a very common practice (see:#1398 (comment) for example) and is in fact a requirement for features that are in a "private" release. We don't support adding private features to our public client library, but this_properties feature allows such customers to use the public client library via this workaround.