Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Support jsonExtension in LoadJobConfig#1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
chalmerlowe merged 5 commits intogoogleapis:mainfromkiraksi:support-jsonextension
Jan 12, 2024

Conversation

@kiraksi
Copy link
Contributor

This PR:

  • Adds jsonExtension as a parameter to LoadJobConfig when loading data from a specified file format
  • It enable users to directly specify the extension within the job configuration and store that information in metadata
  • It allows BQ to Interpret the source format correctly (?)

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • [] Appropriate docs were updated (if necessary) (should autogenerate?)

Fixes#1581 🦕

@product-auto-labelproduct-auto-labelbot added size: mPull request size is medium. api: bigqueryIssues related to the googleapis/python-bigquery API. labelsDec 14, 2023
@kiraksi
Copy link
ContributorAuthor

kiraksi commentedDec 19, 2023•
edited
Loading

We are unable to find jsonExtension explicitly in LoadJobConfig BigQuery documentation, only some mentions of it. This PR is on hold until we can get clarity on this.

Edit: Was able to find jsonExtension, however its documentation was being suppressed as the person working on it left Google and did not unsurppress it. This was fix and the documentation was updated

@product-auto-labelproduct-auto-labelbot added size: sPull request size is small. and removed size: mPull request size is medium. labelsJan 11, 2024
@kiraksikiraksi marked this pull request as ready for reviewJanuary 11, 2024 05:02
@kiraksikiraksi requested review froma team ascode ownersJanuary 11, 2024 05:02
@kiraksikiraksi removed the request for review fromalvarowolfxJanuary 11, 2024 18:29
Copy link
Collaborator

@chalmerlowechalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@chalmerlowechalmerlowe merged commit0fd7347 intogoogleapis:mainJan 12, 2024
@kiraksikiraksi deleted the support-jsonextension branchJanuary 17, 2024 14:01
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chalmerlowechalmerlowechalmerlowe approved these changes

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support jsonExtension in LoadJobConfig

2 participants

@kiraksi@chalmerlowe
[8]ページ先頭
©2009-2025 Movatter.jp