Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: keepRowIterator.total_rows populated after iteration#1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tswast merged 2 commits intomainfromissue589-total_rows
Dec 8, 2023

Conversation

@tswast
Copy link
Contributor

Split out of#1722

This was being reset in some cases when the rows were all available in the first page of results.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#589 🦕

This was being reset in some cases whenthe rows were all available in thefirst page of results.
@tswasttswast requested review froma team ascode ownersDecember 8, 2023 02:01
@product-auto-labelproduct-auto-labelbot added size: sPull request size is small. api: bigqueryIssues related to the googleapis/python-bigquery API. labelsDec 8, 2023
@tswast
Copy link
ContributorAuthor

Alternatively, we could populatetotalRows here if present:

Not sure which to prefer, but this way involved updating fewer tests.

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@tswasttswastenabled auto-merge (squash)December 8, 2023 21:36
@tswasttswast added the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelDec 8, 2023
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelDec 8, 2023
@tswasttswast merged commit8482f47 intomainDec 8, 2023
@tswasttswast deleted the issue589-total_rows branchDecember 8, 2023 22:13
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@partheapartheaparthea approved these changes

@chalmerlowechalmerloweAwaiting requested review from chalmerlowechalmerlowe was automatically assigned from googleapis/api-bigquery

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Provide support for synchronous queries through the v2/projects/{projectId}/queries endpoint

3 participants

@tswast@parthea@yoshi-kokoro

[8]ページ先頭

©2009-2025 Movatter.jp