Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: ensure query job retry has longer deadline than API request deadline#1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tswast merged 1 commit intomainfromjob_retry
Nov 21, 2023

Conversation

@tswast
Copy link
Contributor

In cases where we can't disambiguate API failure from job failure, this ensures we can still retry the job at least once.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Related to internal issue 311358887
🦕

…lineIn cases where we can't disambiguate API failure from job failure,this ensures we can still retry the job at least once.
@tswasttswast requested review froma team ascode ownersNovember 21, 2023 15:52
@product-auto-labelproduct-auto-labelbot added size: sPull request size is small. api: bigqueryIssues related to the googleapis/python-bigquery API. labelsNov 21, 2023
@tswasttswast requested a review fromLinchinNovember 21, 2023 15:56
@tswasttswast merged commit5573579 intomainNov 21, 2023
@tswasttswast deleted the job_retry branchNovember 21, 2023 17:51
kiraksi pushed a commit to kiraksi/python-bigquery that referenced this pull requestNov 27, 2023
…line (googleapis#1734)In cases where we can't disambiguate API failure from job failure,this ensures we can still retry the job at least once.
kiraksi added a commit that referenced this pull requestNov 28, 2023
…nto pandas extra (#1726)* feat: Introduce compatibility with native namespace packages* Update copyright year* removed pkg_resources from all test files and moved importlib into pandas extra* feat: removed pkg_resources from all test files and moved importlib into pandas extra* Adding no cover tag to test code* reformatted with black* undo revert* perf: use the first page a results when `query(api_method="QUERY")` (#1723)* perf: use the first page a results when `query(api_method="QUERY")`* add tests* respect max_results with cached page* respect page_size, also avoid bqstorage if almost fully downloaded* skip true test if bqstorage not installed* coverage* fix: ensure query job retry has longer deadline than API request deadline (#1734)In cases where we can't disambiguate API failure from job failure,this ensures we can still retry the job at least once.* fix: `load_table_from_dataframe` now assumes there may be local null values (#1735)Even if the remote schema is REQUIREDThank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea- [ ] Ensure the tests and linter pass- [ ] Code coverage does not decrease (if any source code was changed)- [ ] Appropriate docs were updated (if necessary)Fixes#1692 🦕* chore: standardize samples directory - delete unneeded dependencies (#1732)* chore: standardize samples directory = delete unneeded dependencies* Removed unused import for linter* fix: move grpc, proto-plus and protobuf packages to extras (#1721)* chore: move grpc, proto-plus and protobuff packages to extras* formatted with black* feat: add `job_timeout_ms` to job configuration classes (#1675)* fix: adds new property and tests* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md* updates docs to correct a sphinx failure* Updates formatting* Update tests/system/test_query.py* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md* Update google/cloud/bigquery/job/base.py* updates one test and uses int_or_none* Update tests/system/test_query.pytesting something.* Update tests/system/test_query.py* testing coverage feature* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md* minor edits* tweaks to noxfile for testing purposes* add new test to base as experiment* adds a test, updates import statements* add another test* edit to tests* formatting fixes* update noxfile to correct debug code* removes unneeded comments.---------Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>---------Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>Co-authored-by: Tim Swast <swast@google.com>* remove unnecessary version checks* undo bad commit, remove unneeded version checks* Revert "undo bad commit, remove unneeded version checks"This reverts commit5c82dcf.* Revert "remove unnecessary version checks"This reverts commit9331a7e.* revert bad changes, remove pkg_resources from file* after clarification, reimplement changes and ignore 3.12 tests* reformatted with black* removed minimum check* updated pandas installed version check---------Co-authored-by: Anthonios Partheniou <partheniou@google.com>Co-authored-by: Tim Swast <swast@google.com>Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@LinchinLinchinLinchin approved these changes

@prash-miprash-miAwaiting requested review from prash-miprash-mi was automatically assigned from googleapis/api-bigquery

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tswast@Linchin

[8]ページ先頭

©2009-2025 Movatter.jp