- Notifications
You must be signed in to change notification settings - Fork321
fix: AccessEntry API representation parsing#1682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Linchin merged 4 commits intogoogleapis:mainfromjonathan-ostrander:access_entry_repr_fixOct 19, 2023
Merged
fix: AccessEntry API representation parsing#1682
Linchin merged 4 commits intogoogleapis:mainfromjonathan-ostrander:access_entry_repr_fixOct 19, 2023
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Overriding the `AccessEntry#_properties` with a deep copy of the API resource overwrites the `role` property set in `AccessEntry.__init__` which isn't present in the resource if the `role` is set to `None`. This causes `AccessEntry`s generated from API representations to no longer evaluate to equal with equivalent `AccessEntry` resources instantiated through `AccessEntry.__init__`. The added unit test fails without the change and passes with the change.
Contributor
Linchin commentedOct 18, 2023
Hi@jonathan-ostrander, thank you so much for your contribution! The PR looks good, but it seems the lint test failed. As seen in the kokoro results: Please see theinstructions in the contribution doc for more info on coding style. If you need any help, please let us know! :) |
Linchin requested changesOct 18, 2023
Contributor
Linchin left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
please fix linting error
ContributorAuthor
jonathan-ostrander commentedOct 18, 2023
Linchin approved these changesOct 19, 2023
This was referencedNov 7, 2023
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
api: bigqueryIssues related to the googleapis/python-bigquery API. size: sPull request size is small.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overriding the
AccessEntry#_propertieswith a deep copy of the API resource overwrites theroleproperty set inAccessEntry.__init__which isn't present in the resource if theroleis set toNone. This causesAccessEntrys generated from API representations to no longer evaluate to equal with equivalentAccessEntryresources instantiated throughAccessEntry.__init__. The added unit test fails without the change and passes with the change.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes#1681 🦕