NotificationsYou must be signed in to change notification settings
Fork321
Star786

feat: add`Model.transform_columns` property#1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

tswast merged 19 commits intogoogleapis:mainfromSalemJorden:Salem

Oct 12, 2023

Merged

feat: add`Model.transform_columns` property#1661

tswast merged 19 commits intogoogleapis:mainfromSalemJorden:Salem

Oct 12, 2023

Conversation

Copy link

Contributor

SalemJorden commentedSep 18, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

added TransformColumns class + corresponding unit tests

9507821

product-auto-labelbot added size: m

Pull request size is medium.

api: bigqueryIssues related to the googleapis/python-bigquery API. labels

Sep 18, 2023

SalemJordenand others added3 commits

September 18, 2023 10:28

Merge branch 'main' into Salem

9ef24fe

Merge branch 'main' into Salem

209455a

TransformColumns:@Property'getters' and 'setters' + updated unit tests

61eb437

SalemJorden changed the title~~added TransformColumns class + corresponding unit tests~~feat: addModel.transform_columns property

Sep 20, 2023

tswast requested changes

Sep 22, 2023

View reviewed changes

google/cloud/bigquery/model.py Outdated

		]

		@property
		deftransform_columns(self)->Sequence[Dict[str,Any]]:

Copy link

Contributor

tswastSep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please make this return a sequence of your new TransformColumn objects instead of a sequence of dictionaries.

google/cloud/bigquery/model.py OutdatedShow resolvedHide resolved

tests/unit/model/test_model.py OutdatedShow resolvedHide resolved

tswast added the kokoro:force-runAdd this label to force Kokoro to re-run the tests. label

Sep 22, 2023

yoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests. label

Sep 22, 2023

SalemJorden added2 commits

September 25, 2023 15:47

changes based on code review notes

4902ee4

changes based on code review

0049688

SalemJorden requested a review fromtswast

September 25, 2023 20:53

tswast reviewed

Sep 27, 2023

View reviewed changes

google/cloud/bigquery/model.py OutdatedShow resolvedHide resolved

tests/unit/model/test_model.py OutdatedShow resolvedHide resolved

.coverage.salemb-macbookpro.roam.internal.75772.634632 OutdatedShow resolvedHide resolved

SalemJorden added6 commits

September 28, 2023 11:01

Updated args

bcdee27

updated return type annotation,returning new sequence of TransformCol…

4976284

…umn objects,updated test

deleted unecesscary coverage file

43d4267

return a sequence of your new TransformColumn objects instead of a se…

781c655

…quence of dictionaries.

code review changes

8a2a6fc

updated tests

026cc4d

tswast requested changes

Oct 10, 2023

View reviewed changes

Copy link

Contributor

tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

TransformColumn is looking quite good now. A few more comments to address, please.

google/cloud/bigquery/model.py OutdatedShow resolvedHide resolved

tests/unit/model/test_model.py OutdatedShow resolvedHide resolved

SalemJorden added2 commits

October 11, 2023 14:23

test restoration & returning Model instead of TransformColumn

481dfb8

code review changes

46f9843

tswast marked this pull request as ready for review

October 11, 2023 20:36

tswast requested review froma team ascode owners

October 11, 2023 20:36

Merge branch 'main' into Salem

56c5ef9

tswast reviewed

Oct 11, 2023

View reviewed changes

google/cloud/bigquery/model.py OutdatedShow resolvedHide resolved

Update google/cloud/bigquery/model.py

0cf4241

tswast reviewed

Oct 11, 2023

View reviewed changes

tests/unit/model/test_model.py Outdated

		"name":"transform_name" ,
		"type": {"typeKind":"INT64"},
		"transformSql":"transform_sql"
		}]

Copy link

Contributor

tswastOct 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let's run "nox -r -s blacken" from the terminal to format this.

pull from main branch

c9cacbe

tswast approved these changes

Oct 11, 2023

View reviewed changes

tswastenabled auto-merge (squash)

October 11, 2023 20:55

tswast reviewed

Oct 11, 2023

View reviewed changes

google/cloud/bigquery/model.py OutdatedShow resolvedHide resolved

tests/unit/model/test_model.py OutdatedShow resolvedHide resolved

tswast added2 commits

October 11, 2023 16:50

Update tests/unit/model/test_model.py

56c7802

address type and lint errors

2aa8edf

tswast added automergeMerge the pull request once unit tests and other checks pass. and removed automergeMerge the pull request once unit tests and other checks pass. labels

Oct 12, 2023

tswast merged commit5ceed05 intogoogleapis:main

Oct 12, 2023