Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: type annotations include Optional when None is accepted#1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gcf-merge-on-green merged 6 commits intomainfromtswast-typing
Jun 22, 2023

Conversation

@tswast
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#1545 🦕

@tswasttswast requested review froma team ascode ownersApril 18, 2023 19:45
@tswasttswast requested a review fromGaoleMengApril 18, 2023 19:45
@product-auto-labelproduct-auto-labelbot added size: mPull request size is medium. api: bigqueryIssues related to the googleapis/python-bigquery API. labelsApr 18, 2023
@tswasttswast mentioned this pull requestApr 18, 2023
@tswasttswast requested review fromchalmerlowe and removed request forGaoleMengJune 2, 2023 15:59
Copy link
Collaborator

@chalmerlowechalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@chalmerlowechalmerlowe added the automergeMerge the pull request once unit tests and other checks pass. labelJun 22, 2023
@gcf-merge-on-greengcf-merge-on-greenbot merged commit6c1ab80 intomainJun 22, 2023
@gcf-merge-on-greengcf-merge-on-greenbot deleted the tswast-typing branchJune 22, 2023 15:30
@gcf-merge-on-greengcf-merge-on-greenbot removed the automergeMerge the pull request once unit tests and other checks pass. labelJun 22, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chalmerlowechalmerlowechalmerlowe approved these changes

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Typing of timeout

3 participants

@tswast@chalmerlowe@meredithslota
[8]ページ先頭
©2009-2025 Movatter.jp