NotificationsYou must be signed in to change notification settings
Fork321
Star786

feat: add date, datetime, time, timestamp dtype to to_dataframe#1547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

chelsea-lin merged 1 commit intomainfrommain_chelsealin_typesmapper

Apr 18, 2023

Merged

feat: add date, datetime, time, timestamp dtype to to_dataframe#1547

chelsea-lin merged 1 commit intomainfrommain_chelsealin_typesmapper

Apr 18, 2023

Conversation

Copy link

Contributor

chelsea-lin commentedApr 7, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as aAdd 'date_dtype', 'datetime_dtype', 'time_dtype' and 'timetamp_dtype' to the 'to_dataframe' APIs #1546.
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes#1546 🦕

chelsea-lin requested review froma team ascode owners

April 7, 2023 00:32

chelsea-lin requested a review fromshollyman

April 7, 2023 00:32

product-auto-labelbot added size: l

Pull request size is large.

api: bigqueryIssues related to the googleapis/python-bigquery API. labels

Apr 7, 2023

chelsea-lin requested a review fromtswast

April 7, 2023 00:33

chelsea-lin force-pushed themain_chelsealin_typesmapper branch from3075ecd toef363e4Compare

April 7, 2023 03:30

tswast requested changes

Apr 7, 2023

View reviewed changes

Copy link

Contributor

tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Loving it so far.

Would you do me a favor and add a system test with "extreme" values like this one, but instead of looking for "object" dtypes, we pass in theArrowDtype?

python-bigquery/tests/system/test_pandas.py

Line 1063 ine1aa921

deftest_list_rows_nullable_scalars_extreme_dtypes(

google/cloud/bigquery/table.pyShow resolvedHide resolved

chelsea-lin force-pushed themain_chelsealin_typesmapper branch from5a8c0f6 toac07193Compare

April 10, 2023 17:29

chelsea-lin requested a review fromtswast

April 10, 2023 17:30

chelsea-lin force-pushed themain_chelsealin_typesmapper branch fromac07193 tof560802Compare

April 12, 2023 00:03

chelsea-lin added the kokoro:runAdd this label to force Kokoro to re-run the tests. label

Apr 12, 2023

tswast added kokoro:force-runAdd this label to force Kokoro to re-run the tests. and removed kokoro:runAdd this label to force Kokoro to re-run the tests. labels

Apr 12, 2023

tswast approved these changes

Apr 12, 2023

View reviewed changes

Copy link

Contributor

tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

parthea added kokoro:run

Add this label to force Kokoro to re-run the tests.

kokoro:force-runAdd this label to force Kokoro to re-run the tests. and removed kokoro:force-runAdd this label to force Kokoro to re-run the tests. labels

Apr 12, 2023

tswast added kokoro:run

Add this label to force Kokoro to re-run the tests.

kokoro:force-runAdd this label to force Kokoro to re-run the tests. and removed kokoro:run

Add this label to force Kokoro to re-run the tests.

kokoro:force-runAdd this label to force Kokoro to re-run the tests. labels

Apr 13, 2023