Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: Revise update_table_expiration sample#1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
thejaredchapman merged 2 commits intomainfromissue790-update_table_expiration
Sep 15, 2023

Conversation

@thejaredchapman
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards#790 🦕

@snippet-bot
Copy link

snippet-botbot commentedJan 9, 2023•
edited
Loading

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated bysnippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, addsnippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-labelproduct-auto-labelbot added size: mPull request size is medium. api: bigqueryIssues related to the googleapis/python-bigquery API. samplesIssues that are directly related to samples. labelsJan 9, 2023
Copy link
Contributor

@tswasttswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good! But let's updatedocs/snippets.py with a comment that we should delete the duplicate sample there once we update cloud.google.com.

@tswast
Copy link
Contributor

@thejaredchapman I think we might want to rebase this just so we can fixup the CLA check.

Would love to see the commit for#1516 as part of this PR instead of as a second PR, too.

@thejaredchapmanthejaredchapmanenabled auto-merge (squash)March 8, 2023 21:27
@meredithslotameredithslota requested a review froma team as acode ownerApril 11, 2023 20:39
@meredithslotameredithslota added the cla: yesThis human has signed the Contributor License Agreement. labelApr 11, 2023
@meredithslota
Copy link
Contributor

meredithslota commentedApr 11, 2023•
edited
Loading

Manually applied thecla: yes label since it's related to a Xoogler contribution made during employment.

edit This didn't work, ha — someone will need to click the "request exception" link in the CLA checker log.

@google-clagoogle-clabot added cla: noThis human has *not* signed the Contributor License Agreement. and removed cla: yesThis human has signed the Contributor License Agreement. labelsApr 11, 2023
@tswasttswastforce-pushed theissue790-update_table_expiration branch from494f9b7 todeff4adCompareSeptember 15, 2023 16:30
@google-clagoogle-clabot added cla: yesThis human has signed the Contributor License Agreement. and removed cla: noThis human has *not* signed the Contributor License Agreement. labelsSep 15, 2023
@tswast
Copy link
Contributor

I've squashed all commits and re-pushed. I believe that should resolve the CLA issue.

@thejaredchapmanthejaredchapman merged commit03194e0 intomainSep 15, 2023
@thejaredchapmanthejaredchapman deleted the issue790-update_table_expiration branchSeptember 15, 2023 18:17
tswast added a commit that referenced this pull requestOct 4, 2023
New version of this sample added in#1457 and migrated to in the docs in internal change 570781706.
Linchin added a commit that referenced this pull requestOct 19, 2023
…#1673)New version of this sample added in#1457 and migrated to in the docs in internal change 570781706.Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tswasttswasttswast approved these changes

@Neenu1995Neenu1995Awaiting requested review from Neenu1995

@nicainnicainAwaiting requested review from nicainnicain is a code owner automatically assigned from googleapis/python-samples-owners

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.samplesIssues that are directly related to samples.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thejaredchapman@tswast@meredithslota
[8]ページ先頭
©2009-2025 Movatter.jp