Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: revise create table cmek sample#1452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tswast merged 4 commits intomainfromissue790-create_table_cmek
Jan 6, 2023

Conversation

@Mattix23
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards#790 🦕

@Mattix23Mattix23 requested a review froma teamJanuary 3, 2023 20:48
@Mattix23Mattix23 requested review froma team ascode ownersJanuary 3, 2023 20:48
@snippet-bot
Copy link

snippet-botbot commentedJan 3, 2023•
edited
Loading

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated bysnippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, addsnippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-labelproduct-auto-labelbot added size: mPull request size is medium. api: bigqueryIssues related to the googleapis/python-bigquery API. samplesIssues that are directly related to samples. labelsJan 3, 2023
@tswast
Copy link
Contributor

Merging blocked by#1453

@tswasttswast added the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelJan 6, 2023
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelJan 6, 2023
Copy link
Contributor

@tswasttswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

I've granted what I believe to be the necessary permissions in the cloud-samples-tests project to address the failures in the Samples test session.

@tswasttswastenabled auto-merge (squash)January 6, 2023 19:59
@tswasttswast merged commit57740e4 intomainJan 6, 2023
@tswasttswast deleted the issue790-create_table_cmek branchJanuary 6, 2023 20:25
@release-pleaserelease-pleasebot mentioned this pull requestJan 6, 2023
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull requestApr 17, 2023
* docs: revise create table cmek sample* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.mdCo-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@partheapartheaparthea left review comments

@tswasttswasttswast approved these changes

@loferrisloferrisAwaiting requested review from loferris

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.samplesIssues that are directly related to samples.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Mattix23@tswast@parthea@yoshi-kokoro
[8]ページ先頭
©2009-2025 Movatter.jp