Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: revise label table code samples#1451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tswast merged 8 commits intomainfromissue790-label_table
Jan 6, 2023
Merged

Conversation

@Mattix23
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards#790 🦕

@Mattix23Mattix23 requested a review froma teamJanuary 3, 2023 19:59
@Mattix23Mattix23 requested review froma team ascode ownersJanuary 3, 2023 19:59
@product-auto-labelproduct-auto-labelbot added the size: mPull request size is medium. labelJan 3, 2023
@snippet-bot
Copy link

snippet-botbot commentedJan 3, 2023•
edited
Loading

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated bysnippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, addsnippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-labelproduct-auto-labelbot added api: bigqueryIssues related to the googleapis/python-bigquery API. samplesIssues that are directly related to samples. labelsJan 3, 2023
@tswasttswastenabled auto-merge (squash)January 3, 2023 20:47
table_id = "your-project.your_dataset.your_table_name"

# [END bigquery_label_table]
table_id = orig_table_id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could you clarify the reason thatorig_table_id is needed? Could we removeorig_table_id and just havetable_id?

@tswasttswast merged commit14ae1f2 intomainJan 6, 2023
@tswasttswast deleted the issue790-label_table branchJanuary 6, 2023 18:42
@release-pleaserelease-pleasebot mentioned this pull requestJan 6, 2023
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull requestApr 17, 2023
* docs: revise label table code samples* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md* added TODO to clean up snippets.pyCo-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>Co-authored-by: Tim Swast <swast@google.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@partheapartheaparthea left review comments

@tswasttswasttswast approved these changes

@atulepatulepAwaiting requested review from atulepatulep is a code owner automatically assigned from googleapis/python-samples-owners

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.samplesIssues that are directly related to samples.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mattix23@tswast@parthea
[8]ページ先頭
©2009-2025 Movatter.jp