Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

deps: remove upper bound on packaging dependency#1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tswast merged 6 commits intomainfromissue1435-remove-packaging-upper-bound
Jan 13, 2023

Conversation

@tswast
Copy link
Contributor

@tswasttswast commentedDec 13, 2022•
edited
Loading

Towards#1435

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards#1435
Fixes#1400
🦕

di, hirosassa, and hugovk reacted with thumbs up emoji
@tswasttswast requested a review froma teamDecember 13, 2022 22:38
@tswasttswast requested a review froma team as acode ownerDecember 13, 2022 22:38
@product-auto-labelproduct-auto-labelbot added size: xsPull request size is extra small. api: bigqueryIssues related to the googleapis/python-bigquery API. labelsDec 13, 2022
Copy link
Collaborator

@chalmerlowechalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@chalmerlowechalmerlowe added the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelDec 14, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelDec 14, 2022
@tswast
Copy link
ContributorAuthor

TODO: Need to investigate unit test failure:

______ TestPyarrowVersions.test_installed_version_returns_parsed_version _______self = <tests.unit.test__helpers.TestPyarrowVersions testMethod=test_installed_version_returns_parsed_version>    def test_installed_version_returns_parsed_version(self):        versions = self._object_under_test()        with mock.patch("pyarrow.__version__", new="1.2.3"):            version = versions.installed_version>       assert version.major == 1E       AttributeError: 'Version' object has no attribute 'major'

Copy link

@hirosassahirosassa left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for your PR. I'm also struggling this problem.

I added a small comment.

opentelemetry-api==1.1.0
opentelemetry-instrumentation==0.20b0
opentelemetry-sdk==1.1.0
packaging==14.3
Copy link

@hirosassahirosassaJan 4, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@tswast It looks thatthe problem you suggest comes from this version constraint.

v14.3 of packaging has nomajor attribute:
https://github.com/pypa/packaging/blob/14.3/packaging/version.py#L268-L280

I think we need to update the lower bound, too.

tswast reacted with heart emoji

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@parthea
Copy link
Contributor

@tswast See related issue#1400

hirosassa reacted with thumbs up emoji

@tswasttswastenabled auto-merge (squash)January 13, 2023 17:15
@tswasttswast merged commit6088129 intomainJan 13, 2023
@tswasttswast deleted the issue1435-remove-packaging-upper-bound branchJanuary 13, 2023 17:41
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull requestApr 17, 2023
* deps: remove upper bound on packaging dependencyTowardsgoogleapis#1435* install prerelease version of packaging* bump minimum packaging versionCo-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chalmerlowechalmerlowechalmerlowe approved these changes

@Neenu1995Neenu1995Awaiting requested review from Neenu1995

+1 more reviewer

@hirosassahirosassahirosassa left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tswasttswast

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: xsPull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Require packaging>=20.0

5 participants

@tswast@parthea@hirosassa@chalmerlowe@yoshi-kokoro
[8]ページ先頭
©2009-2025 Movatter.jp