- Notifications
You must be signed in to change notification settings - Fork321
Fix: Refactors code to account for a tdqm code deprecation#1357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…cation' into fix-tdqm-code-deprecation
dandhlee approved these changesSep 19, 2022
CollaboratorAuthor
chalmerlowe commentedSep 21, 2022
Fixes#1146 |
This was referencedOct 4, 2022
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull requestApr 17, 2023
…s#1357)* tests some options* refactors to use tqdm.* notation* refactors tqdm function calls to account for deprecation warning* refactors _tqdm_helpers to account for tqdm deprecation warnings* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md* removes an extraneous reference to ipywidgets* removes unneeded import* removes import and fixes linting errorCo-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
api: bigqueryIssues related to the googleapis/python-bigquery API. size: sPull request size is small.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tqdmhas changed elements of their codebase and issued a deprecation warning. This change implements several refactors to account for those changes and mitigate the deprecation warning.The
tdqmlibrary would issue the following deprecation warning:```Please use
tqdm.notebook.tqdminstead of `tqdm.tqdm_notebook