- Notifications
You must be signed in to change notification settings - Fork321
fix: validate opentelemetry span job attributes have values#1327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
There are several job properties that are optional. Existingopentelemetry instrumentation disallows span attribute keys withoutappropriate values, so this change validates field presence beforepropagating.
ContributorAuthor
shollyman commentedAug 25, 2022
prerelease failures appear unrelated to this PR. |
parthea approved these changesAug 27, 2022
Contributor
parthea commentedAug 27, 2022
I've openedgoogleapis/synthtool#1556 to fix the pre-release failures |
chalmerlowe approved these changesAug 29, 2022
Collaborator
chalmerlowe left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
ContributorAuthor
shollyman commentedAug 29, 2022
Merging |
This was referencedOct 4, 2022
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull requestApr 17, 2023
…is#1327)fix: validate opentelemetry span job attributes have valuesThere are several job properties that are optional. Existingopentelemetry instrumentation disallows span attribute keys withoutappropriate values, so this change validates field presence beforepropagating.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
api: bigqueryIssues related to the googleapis/python-bigquery API. size: sPull request size is small.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
There are several job properties that are optional. Existing
opentelemetry instrumentation disallows span attribute keys without
appropriate values, so this change validates value presence before
propagating.
Fixes:#1140