Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs(samples): table variable fix#1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gcf-merge-on-green merged 21 commits intogoogleapis:mainfromadhiggs:adhiggs-patch-1
Jan 24, 2023

Conversation

@adhiggs
Copy link
Contributor

@adhiggsadhiggs commentedJul 7, 2022
edited by shollyman
Loading

Updated table variable in "# Print row data in tabular format." to point at the correct table_id.

Fixes#1286

@adhiggsadhiggs requested a review froma teamJuly 7, 2022 00:47
@adhiggsadhiggs requested review froma team ascode ownersJuly 7, 2022 00:47
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcfbot commentedJul 7, 2022
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or useautomerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-labelproduct-auto-labelbot added size: xsPull request size is extra small. api: bigqueryIssues related to the googleapis/python-bigquery API. labelsJul 7, 2022
@adhiggsadhiggs changed the titleTable variable fixVariable fixJul 7, 2022
@adhiggsadhiggs changed the titleVariable fixfix: table variable fixJul 7, 2022
Updated table variable in "# Print row data in tabular format." to point at the correct table_id.
@partheaparthea changed the titlefix: table variable fixdocs(samples): table variable fixJul 7, 2022
@partheaparthea added kokoro:runAdd this label to force Kokoro to re-run the tests. kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsJul 7, 2022
@yoshi-kokoroyoshi-kokoro removed kokoro:runAdd this label to force Kokoro to re-run the tests. kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsJul 7, 2022
@adhiggs
Copy link
ContributorAuthor

adhiggs commentedJul 7, 2022
edited
Loading

Not sure how to get these checks to pass. Thoughts?
(And thanks for the assist so far!)

@product-auto-labelproduct-auto-labelbot added the samplesIssues that are directly related to samples. labelJul 8, 2022
@partheaparthea added kokoro:runAdd this label to force Kokoro to re-run the tests. kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsJul 10, 2022
@yoshi-kokoroyoshi-kokoro removed kokoro:runAdd this label to force Kokoro to re-run the tests. kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsJul 10, 2022
@steffnay
Copy link
Contributor

Hey,@adhiggs, theClient.list_rows method accepts typeUnion[Table, TableListItem, TableReference, str] for this parameter, so I am not recognizing the reason for this change.

@adhiggs
Copy link
ContributorAuthor

Hi@steffnay, looping you in on bugs related, stay tuned.

@Vadoid
Copy link

Hi@steffnay this change is for clarity and consistency. In other code samples inhttps://cloud.google.com/bigquery/docs/samples/bigquery-browse-table the table variable passed to methods is 'table_id', except for the last example under "# Print row data in tabular format." where it's 'table', so the last code block wouldn't run while table variable is defined as 'table_id'.

@partheaparthea added kokoro:runAdd this label to force Kokoro to re-run the tests. kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsNov 16, 2022
@yoshi-kokoroyoshi-kokoro removed kokoro:runAdd this label to force Kokoro to re-run the tests. kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsNov 16, 2022
@aribrayaribray added the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelNov 18, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelNov 18, 2022
@adhiggs
Copy link
ContributorAuthor

Hi team! Is there anything blocking this item from being merged in?

@aribrayaribray added kokoro:force-runAdd this label to force Kokoro to re-run the tests. and removed kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsJan 13, 2023
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelJan 13, 2023
@shollymanshollyman added automergeMerge the pull request once unit tests and other checks pass. kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsJan 23, 2023
@yoshi-kokoroyoshi-kokoro removed kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsJan 23, 2023
@gcf-merge-on-greengcf-merge-on-greenbot merged commita71888a intogoogleapis:mainJan 24, 2023
@gcf-merge-on-greengcf-merge-on-greenbot removed the automergeMerge the pull request once unit tests and other checks pass. labelJan 24, 2023
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull requestApr 17, 2023
Updated table variable in "# Print row data in tabular format." to point at the correct table_id.Fixeshttps://togithub.com/googleapis/python-bigquery/issues/1286
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@shollymanshollymanshollyman approved these changes

@partheapartheaparthea approved these changes

@GaoleMengGaoleMengAwaiting requested review from GaoleMeng

@engelkeengelkeAwaiting requested review from engelkeengelke is a code owner automatically assigned from googleapis/python-samples-owners

@steffnaysteffnayAwaiting requested review from steffnay

@aribrayaribrayAwaiting requested review from aribray

Assignees

@steffnaysteffnay

@aribrayaribray

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.samplesIssues that are directly related to samples.size: xsPull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Table variable correction in browse_table_data.py

9 participants

@adhiggs@steffnay@Vadoid@shollyman@parthea@meredithslota@yoshi-kokoro@aribray@dandhlee

[8]ページ先頭

©2009-2025 Movatter.jp