- Notifications
You must be signed in to change notification settings - Fork321
docs(samples): table variable fix#1287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
conventional-commit-lint-gcfbot commentedJul 7, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Updated table variable in "# Print row data in tabular format." to point at the correct table_id.
adhiggs commentedJul 7, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Not sure how to get these checks to pass. Thoughts? |
Fixed spacing issue.
…igquery into adhiggs-patch-1
steffnay commentedJul 12, 2022
Hey,@adhiggs, the |
adhiggs commentedJul 16, 2022
Hi@steffnay, looping you in on bugs related, stay tuned. |
Vadoid commentedJul 18, 2022
Hi@steffnay this change is for clarity and consistency. In other code samples inhttps://cloud.google.com/bigquery/docs/samples/bigquery-browse-table the table variable passed to methods is 'table_id', except for the last example under "# Print row data in tabular format." where it's 'table', so the last code block wouldn't run while table variable is defined as 'table_id'. |
adhiggs commentedDec 1, 2022
Hi team! Is there anything blocking this item from being merged in? |
Updated table variable in "# Print row data in tabular format." to point at the correct table_id.Fixeshttps://togithub.com/googleapis/python-bigquery/issues/1286
Uh oh!
There was an error while loading.Please reload this page.
Updated table variable in "# Print row data in tabular format." to point at the correct table_id.
Fixes#1286