Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(deps): allow pyarrow v8#1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
leahecole merged 1 commit intomainfromallow-pyarrow-v8
May 9, 2022
Merged

fix(deps): allow pyarrow v8#1245

leahecole merged 1 commit intomainfromallow-pyarrow-v8
May 9, 2022

Conversation

@parthea
Copy link
Contributor

No description provided.

@partheaparthea requested a review froma teamMay 9, 2022 15:01
@partheaparthea requested a review froma team as acode ownerMay 9, 2022 15:01
@partheaparthea requested a review fromprash-miMay 9, 2022 15:01
@product-auto-labelproduct-auto-labelbot added size: xsPull request size is extra small. api: bigqueryIssues related to the googleapis/python-bigquery API. labelsMay 9, 2022
@partheaparthea mentioned this pull requestMay 9, 2022
1 task
@leahecoleleahecole merged commitd258690 intomainMay 9, 2022
@leahecoleleahecole deleted the allow-pyarrow-v8 branchMay 9, 2022 15:49
@release-pleaserelease-pleasebot mentioned this pull requestMay 9, 2022
@bnaul
Copy link
Contributor

Sorry to hijack but what's the motivation for always capping the version at whatever is released today? It's a bit frustrating as a user to not be able to use a recently released package because some other dependency has an overly restrictive range of allowed versions. In the opposite case, the user is always free to add saypyarrow<9 to their ownrequirements.txt if they want, but with the current setup I'm pretty much stuck on waiting on another version bump to get everything working.

Appreciate the quick fix here, just wondering if maybe the current system is more hassle than it's worth.

@meredithslota
Copy link
Contributor

@bnaul The reason that we use this approach is because a new major version of a dependency can break users who do not explicitly restrict them viarequirements.txt. We know it is best practice to have arequirements.txt file but not all users do that. In addition, it may take time for our code or samples to be re-written/fixed in order to have compatibility with a new major version, and we'd prefer to err on the side of not accidentally breaking folks. We try to update as soon as possible. Thanks!

waltaskew pushed a commit to waltaskew/python-bigquery that referenced this pull requestJul 20, 2022
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull requestApr 17, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@leahecoleleahecoleleahecole approved these changes

@prash-miprash-miAwaiting requested review from prash-mi

@meredithslotameredithslotaAwaiting requested review from meredithslota

Assignees

@meredithslotameredithslota

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: xsPull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@parthea@bnaul@meredithslota@leahecole

[8]ページ先頭

©2009-2025 Movatter.jp