Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: support using BIGQUERY_EMULATOR_HOST environment variable#1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@abecerrilsalas
Copy link
Contributor

@abecerrilsalasabecerrilsalas commentedApr 19, 2022•
edited by steffnay
Loading

What?

Implemented a BIGQUERY_EMULATOR_HOST environment variable to be used to set the api_endpoint in the python-bigquery client constructor.

Why?

Users have requested this implementation (#1193). Currently there is no logic to check for the existence of a BIGQUERY_EMULATOR_HOST or some similar environment variable

How?

Logic was applied and code was changed in the _helpers.py and client.py files.

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#1193 🦕

@product-auto-labelproduct-auto-labelbot added size: sPull request size is small. api: bigqueryIssues related to the googleapis/python-bigquery API. labelsApr 19, 2022
@abecerrilsalasabecerrilsalas changed the titleabecerrilsalas feature bq emulatorfeat: bq emulatorApr 19, 2022
@steffnaysteffnay self-requested a reviewApril 19, 2022 17:13
Copy link
Contributor

@steffnaysteffnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looking good! Just needing changes to variable naming and then the additional tests you have planned.

@product-auto-labelproduct-auto-labelbot added size: mPull request size is medium. and removed size: sPull request size is small. labelsApr 20, 2022
@abecerrilsalasabecerrilsalas marked this pull request as ready for reviewApril 23, 2022 04:56
@abecerrilsalasabecerrilsalas requested a review froma teamApril 23, 2022 04:56
@abecerrilsalasabecerrilsalas requested a review froma team as acode ownerApril 23, 2022 04:56
@product-auto-labelproduct-auto-labelbot added size: sPull request size is small. and removed size: mPull request size is medium. labelsApr 26, 2022
@steffnaysteffnay changed the titlefeat: bq emulatorfeat: support using BIGQUERY_EMULATOR_HOST environment variableApr 28, 2022
@steffnaysteffnay merged commit39294b4 intogoogleapis:mainApr 28, 2022
waltaskew pushed a commit to waltaskew/python-bigquery that referenced this pull requestJul 20, 2022
…leapis#1222)* feat:adding emulator* apb_feature_bq_emulator_test* apb_feature_bq_emulator_variable_name_change* abecerrilsalas_feature_bq_emulator_typo_changes* feat:fixing var names and start of test* abecerrilsalas_feature_additional_tests* feat: testing update* feat: fixed failed lint test
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull requestApr 17, 2023
…leapis#1222)* feat:adding emulator* apb_feature_bq_emulator_test* apb_feature_bq_emulator_variable_name_change* abecerrilsalas_feature_bq_emulator_typo_changes* feat:fixing var names and start of test* abecerrilsalas_feature_additional_tests* feat: testing update* feat: fixed failed lint test
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@steffnaysteffnaysteffnay approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow setting of api_endpoint via environment variable like google-cloud-storage

2 participants

@abecerrilsalas@steffnay
[8]ページ先頭
©2009-2025 Movatter.jp