Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add--no_query_cache option to%%bigquery magics to disable…#1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tswast merged 2 commits intomainfromb215520997-magics-no-cache
Feb 16, 2022

Conversation

@tswast
Copy link
Contributor

… query cache

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 215520997 🦕

@tswasttswast requested a review froma teamFebruary 16, 2022 19:48
@tswasttswast requested a review froma team as acode ownerFebruary 16, 2022 19:48
@product-auto-labelproduct-auto-labelbot added the api: bigqueryIssues related to the googleapis/python-bigquery API. labelFeb 16, 2022
)
@magic_arguments.argument(
"--no_query_cache",
action="store_true",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not understanding what this "store_true" is about, but it seems consistent with the other arguments.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

That's behavior IPython/Jupyter inherits from argparsehttps://docs.python.org/3/library/argparse.html#action

The gist is that if this argument is present it'll setargs.no_query_cache = True rather than requiring a boolean parameter.

@tswasttswast merged commit7dd30af intomainFeb 16, 2022
@tswasttswast deleted the b215520997-magics-no-cache branchFebruary 16, 2022 23:07
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull requestApr 17, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@shollymanshollymanshollyman approved these changes

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tswast@shollyman

[8]ページ先頭

©2009-2025 Movatter.jp