Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitfa6e13d

Browse files
fix: handle case when expirationMs is None (#1553)
* hotfix: handle case when expirationMs is None* Add test for unsetting table exp* Update tests/unit/test_table.py* Update exp_resource for the unsetting_exp test---------Co-authored-by: Tim Swast <swast@google.com>
1 parent075aa66 commitfa6e13d

File tree

2 files changed

+24
-1
lines changed

2 files changed

+24
-1
lines changed

‎google/cloud/bigquery/table.py‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -687,7 +687,11 @@ def partition_expiration(self, value):
687687

688688
ifself.time_partitioningisNone:
689689
self._properties[api_field]= {"type":TimePartitioningType.DAY}
690-
self._properties[api_field]["expirationMs"]=str(value)
690+
691+
ifvalueisNone:
692+
self._properties[api_field]["expirationMs"]=None
693+
else:
694+
self._properties[api_field]["expirationMs"]=str(value)
691695

692696
@property
693697
defclustering_fields(self):

‎tests/unit/test_table.py‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1190,6 +1190,25 @@ def test_to_api_repr_w_custom_field(self):
11901190
}
11911191
self.assertEqual(resource,exp_resource)
11921192

1193+
deftest_to_api_repr_w_unsetting_expiration(self):
1194+
fromgoogle.cloud.bigquery.tableimportTimePartitioningType
1195+
1196+
dataset=DatasetReference(self.PROJECT,self.DS_ID)
1197+
table_ref=dataset.table(self.TABLE_NAME)
1198+
table=self._make_one(table_ref)
1199+
table.partition_expiration=None
1200+
resource=table.to_api_repr()
1201+
1202+
exp_resource= {
1203+
"tableReference":table_ref.to_api_repr(),
1204+
"labels": {},
1205+
"timePartitioning": {
1206+
"expirationMs":None,
1207+
"type":TimePartitioningType.DAY,
1208+
},
1209+
}
1210+
self.assertEqual(resource,exp_resource)
1211+
11931212
deftest__build_resource_w_custom_field(self):
11941213
dataset=DatasetReference(self.PROJECT,self.DS_ID)
11951214
table_ref=dataset.table(self.TABLE_NAME)

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp